Merged
Conversation
Collaborator
Author
|
SkillDisplay/api-php#8 should be merged and released first. Then raise dependency. |
DanielSiepmann
changed the title
DanielSiepmann
force-pushed
the
bugfix/5-allow-creation-of-content-elements
branch
from
fb77927 to
f82732d
Compare
liayn
reviewed
Jan 22, 2021
liayn
reviewed
Jan 22, 2021
Collaborator
|
Thanks for the great improvement/fix! |
Collaborator
Done. |
Content elements could not be created, since they needed campaigns. In order to retrieve campaigns, the API needs to be created. The API needs settings from current site, which is not available in that context. Therefore the factory is extended to also fetch site and their settings based on page uid. The page uid is available in the context. Since we now interact with guzzle, we add the dependency. Wouldn't be necessary if SDK would have PSR compatible type hints. Also tests were added for code, to keep code coverage. Fixes: #5
The new field was introduced without any label. That label is added, together with description and exclude. This keeps consistency and explanation to editors.
DanielSiepmann
force-pushed
the
bugfix/5-allow-creation-of-content-elements
branch
from
f82732d to
1e3646e
Compare
Collaborator
|
Should be ready for merge, right? |
Collaborator
Author
|
Yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5