Fix tests running while world has not loaded#7379
Merged
Moderocky merged 7 commits intoSkriptLang:dev/featurefrom Jan 9, 2025
Efnilite:fix-test-time
Merged
Fix tests running while world has not loaded#7379Moderocky merged 7 commits intoSkriptLang:dev/featurefrom Efnilite:fix-test-time
Moderocky merged 7 commits intoSkriptLang:dev/featurefrom
Efnilite:fix-test-time
Conversation
Efnilite
added
bug
Member
Uh oh 😬
|
Member
|
You'll need to get a non-spawn chunk. Everything is fine in the spawn chunks |
Moderocky
approved these changes
Jan 7, 2025
sovdeeth
approved these changes
Jan 9, 2025
Member
sovdeeth
left a comment
sovdeeth
left a comment
There was a problem hiding this comment.
looks good, ran the tests 2 extra times to double check
cheeezburga
approved these changes
Jan 9, 2025
cheeezburga
added
the
feature-ready
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* init commit * use chunks * oops * use non-spawn-chunk chunk --------- Co-authored-by: Moderocky <admin@moderocky.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes tests run when the first chunk can be retrieved in the world, ensuring the world is loaded before the tests run.
Target Minecraft Versions: any
Requirements: none
Related Issues: none