HTMLGenerator - fix new line in "since" not working#7396
Merged
APickledWalrus merged 3 commits intoSkriptLang:dev/featurefrom Jan 6, 2025
Merged
HTMLGenerator - fix new line in "since" not working#7396APickledWalrus merged 3 commits intoSkriptLang:dev/featurefrom
APickledWalrus merged 3 commits intoSkriptLang:dev/featurefrom
Conversation
Efnilite
approved these changes
Jan 5, 2025
Member
Efnilite
left a comment
Efnilite
left a comment
There was a problem hiding this comment.
I noticed this but I thought you could make any tag self close and itd just be the same as no self closing 😬
Member
|
This will break the searching feature 😬 |
Member
I can handle that in my PR for it |
AyhamAl-Ali
added
enhancement
Contributor
Author
|
ok after a talk with Pickle, I have reverted my change, and removed the method that changes |
APickledWalrus
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to do yet another doc fix, I shall call it YADF.
Anyways, in my previous PR for the since annotation supporting multiple lines, pickle had made a code suggestion to change
<br>to<br/>.I applied the code suggestion and didn't realize til after the PR was merged (and docs were created) that it did this:
(My fault for not testing... whoopsies)
(all on the same line, but no comma)
This PR fixes that issue by reverting that suggestion:
Might be my biggest PR to date 😂
Target Minecraft Versions: any
Requirements: none
Related Issues: none