Make test parsing faster.#7405
Merged
Moderocky merged 3 commits intoSkriptLang:dev/featurefrom Jan 6, 2025
Merged
Conversation
This reverts commit 52c3b75.
APickledWalrus
approved these changes
Jan 6, 2025
sovdeeth
approved these changes
Jan 6, 2025
erenkarakal
pushed a commit
to erenkarakal/Skript
that referenced
this pull request
Nov 26, 2025
* Testing. * I'll have the third part first, please. * Revert "Testing." This reverts commit 52c3b75.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
EffAssertsyntax's condition regex check is ridiculously slow and it prioritises checking assertions without a message first. Since most have a message (and there are a lot of assertions) this is wasted time and ends up adding a couple of seconds to the parse time.I've moved the no-message option to the third pattern so that it's checked last.
This is not a complete fix: RegexPatternElement needs some optimisation.
Target Minecraft Versions: any
Requirements: none
Related Issues: none