AnyIdentifier #7741
Closed
AnyIdentifier #7741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burbulinis
requested review from
Efnilite and
sovdeeth
and removed request for
a team
Burbulinis
added
the
enhancement
Efnilite
requested changes
Mar 23, 2025
| * | ||
| * @return whether this is an offline player | ||
| */ | ||
| default boolean isOfflinePlayer() { |
Member
There was a problem hiding this comment.
This and the check for protocollib isnt really necessary imo
Member
Author
There was a problem hiding this comment.
I decided to keep it as I think the runtime error could cause users to make issues, though it could be removed
any other thoughts?
Fusezion
suggested changes
Mar 23, 2025
Contributor
Fusezion
left a comment
Fusezion
left a comment
There was a problem hiding this comment.
I'm not sure how I feel about adding changer onto any identifier, since these are uuids they should not be changeable.
sovdeeth
reviewed
Mar 24, 2025
skriptlang-automation
bot
added
the
needs reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an AnyIdentifier class, which holds a UUID and is used for
uuid of ...Target Minecraft Versions: any
Requirements: none
Related Issues: #7675