Add fishing state change event #7755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phill310
requested review from
Pesekjak and
UnderscoreTud
and removed request for
a team
Contributor
|
Duplicate of #7683 |
Contributor
Author
|
Dang must have missed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old fishing event used to trigger for any fishing related activity which could still be useful behavior. With the fishing revamp in 2.10 this was lost when the event was broken into its individual states. This PR attempts to create a new syntax withing the event that triggers no matter which fishing state is called. Also adds an event value for the fishing state although I would love to have more feedback on this since I had no clue what I was doing
Target Minecraft Versions: any
Requirements: none
Related Issues: #7671