Skip to content

Fix function implementations not updating on reload #8408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sovdeeth merged 2 commits into from
Jan 29, 2026
Merged

Fix function implementations not updating on reload #8408

sovdeeth merged 2 commits into from
Jan 29, 2026
+10 −4

Conversation

@Efnilite
Copy link
Member

@Efnilite Efnilite commented Jan 26, 2026

Problem

Fixes function implementations in different files not updating when a function in a specific file is reloaded.

Solution

Invalidate all function implementations when that function's structure is unloaded.

Testing Completed

Manual testing.

Supporting Information

Completes: #8371
Related: none
AI assistance: none

@Efnilite Efnilite requested a review from a team as a code owner January 26, 2026 19:37
@Efnilite Efnilite requested review from Burbulinis and cheeezburga and removed request for a team January 26, 2026 19:37
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jan 26, 2026
@Efnilite Efnilite linked an issue Jan 26, 2026 that may be closed by this pull request
Functions called in different files don't update on reload #8371
Open
1 task
@Efnilite Efnilite added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jan 26, 2026
sovdeeth
sovdeeth approved these changes Jan 26, 2026
View reviewed changes
Copy link
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simpler than I thought!

@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Jan 26, 2026
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Jan 26, 2026
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Jan 26, 2026
@sovdeeth sovdeeth merged commit 687d23e into dev/patch Jan 29, 2026
9 checks passed
@skriptlang-automation skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jan 29, 2026
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Jan 29, 2026
@skriptlang-automation skriptlang-automation bot removed the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sovdeeth sovdeeth sovdeeth approved these changes

@Pesekjak Pesekjak Pesekjak approved these changes

@cheeezburga cheeezburga Awaiting requested review from cheeezburga cheeezburga is a code owner automatically assigned from SkriptLang/core-developers

@Burbulinis Burbulinis Awaiting requested review from Burbulinis Burbulinis is a code owner automatically assigned from SkriptLang/core-developers

Assignees

No one assigned

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

2.14 Releases
Status: Done - Awaiting Release

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Functions called in different files don't update on reload

4 participants

@Efnilite @sovdeeth @Pesekjak