Skip to content

Lower ExprParse priority to PME#8542

Merged
UnderscoreTud merged 2 commits intoSkriptLang:dev/patchfrom
bluelhf:fix/lower-expr-parse-default-priority
May 1, 2026
Merged

Lower ExprParse priority to PME#8542
UnderscoreTud merged 2 commits intoSkriptLang:dev/patchfrom
bluelhf:fix/lower-expr-parse-default-priority

Conversation

@bluelhf
Copy link
Copy Markdown
Contributor

@bluelhf bluelhf commented Apr 15, 2026

Problem

Currently, uuid of text argument parsed as player is parsed as (uuid of text argument) parsed as player through the converter chain ((String -> World)ExprUuid -> String)ExprParse.

This happens because ExprParse has higher priority than property expressions: ExprParse has priority COMBINED, as compared to properties' PropertyExpression.DEFAULT_PRIORITY. This default priority for property expressions is between COMBINED and PATTERN_MATCHES_EVERYTHING (hereafter PME).

ExprParse is thus identified first when parsing the expression, leaving the remaining string uuid of text argument to be parsed by ExprUUID via a conversion to World.

Solution

The priority of ExprParse is lowered to PME, which means property expressions now take precedence over the parse expression. uuid of text argument parsed as player will be parsed as uuid of (text argument parsed as player).

Testing Completed

  • Ran quickTest to verify no current tests break as a result of the change
  • Thought really hard for some minutes about ways to break it, but couldn't come up with any

Supporting Information

It seems unlikely that something could break, as it would require a string property that is valid both on strings and on the result type of ExprParse. The trivial case is parsing as text, but this is forbidden by ExprParse.


Completes: #8541
Related: none
AI assistance: GitHub Copilot tried to autocomplete but was not used due to lacklustre performance

@bluelhf bluelhf requested a review from a team as a code owner April 15, 2026 11:34
@bluelhf bluelhf requested review from Efnilite and Pesekjak and removed request for a team April 15, 2026 11:34
@skriptlang-automation skriptlang-automation Bot added the needs reviews A PR that needs additional reviews label Apr 16, 2026
@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Apr 20, 2026
@skriptlang-automation skriptlang-automation Bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Apr 25, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Merge in 2.15 Releases Apr 25, 2026
@UnderscoreTud UnderscoreTud merged commit 22e77b8 into SkriptLang:dev/patch May 1, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Awaiting Merge to Done - Awaiting Release in 2.15 Releases May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Feature request, an issue about something that could be improved, or a PR improving something. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version.

Projects

Status: Done - Awaiting Release

Development

Successfully merging this pull request may close these issues.

6 participants