Skip to content

Add simple SyntaxInfo builder methods#8709

Merged
APickledWalrus merged 4 commits into
dev/featurefrom
feature/simple-syntax-infos
Jun 26, 2026
Merged

Add simple SyntaxInfo builder methods#8709
APickledWalrus merged 4 commits into
dev/featurefrom
feature/simple-syntax-infos

Conversation

@APickledWalrus

Copy link
Copy Markdown
Member

Problem

I have seen some feedback (and experienced it myself) about the builder approach being a bit verbose when building a very simple syntax info.

Solution

Adds some utility simple methods to the SyntaxInfo classes. Consider:

syntaxRegistry.register(SyntaxRegistry.EFFECT, SyntaxInfo.builder(EffActionBar.class)
	.supplier(EffActionBar::new)
	.addPattern("send [the] action[ ]bar [with text] %object% [to %audiences%]")
	.build());

versus

syntaxRegistry.register(SyntaxRegistry.EFFECT, SyntaxInfo.simple(EffActionBar.class, EffActionBar::new,
	"send [the] action[ ]bar [with text] %object% [to %audiences%]"));

Testing Completed

Minor in-game testing of swapping an existing syntax

Supporting Information


Completes: none
Related: none
AI assistance: none

@APickledWalrus APickledWalrus requested a review from a team as a code owner June 17, 2026 16:52
@APickledWalrus APickledWalrus requested review from cheeezburga and erenkarakal and removed request for a team June 17, 2026 16:52
@skriptlang-automation skriptlang-automation Bot added needs reviews A PR that needs additional reviews needs triage An issue that hasn't been classified or verified yet labels Jun 17, 2026
@skriptlang-automation

This comment has been minimized.

@skriptlang-automation skriptlang-automation Bot added the feature Pull request adding a new feature. label Jun 17, 2026
@skriptlang-automation skriptlang-automation Bot removed the needs triage An issue that hasn't been classified or verified yet label Jun 17, 2026
@skriptlang-automation skriptlang-automation Bot moved this to In Review in 2.16 Releases Jun 17, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Merge in 2.16 Releases Jun 22, 2026
@skriptlang-automation skriptlang-automation Bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Jun 22, 2026
@APickledWalrus APickledWalrus merged commit 804c71a into dev/feature Jun 26, 2026
14 checks passed
@APickledWalrus APickledWalrus deleted the feature/simple-syntax-infos branch June 26, 2026 20:17
@skriptlang-automation skriptlang-automation Bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jun 26, 2026
@github-project-automation github-project-automation Bot moved this from Awaiting Merge to Done - Awaiting Release in 2.16 Releases Jun 26, 2026
@skriptlang-automation skriptlang-automation Bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. feature Pull request adding a new feature.

Projects

Status: Done - Awaiting Release

Development

Successfully merging this pull request may close these issues.

3 participants