Skip to content

Proper toString for Simple Events#8729

Merged
sovdeeth merged 1 commit into
SkriptLang:dev/featurefrom
AnOwlBe:ToStringForSimpleEvent
Jun 28, 2026
Merged

Proper toString for Simple Events#8729
sovdeeth merged 1 commit into
SkriptLang:dev/featurefrom
AnOwlBe:ToStringForSimpleEvent

Conversation

@AnOwlBe

@AnOwlBe AnOwlBe commented Jun 28, 2026

Copy link
Copy Markdown

Problem

Currently every simpleevent has the same toString: "simple event" unless they are merged into its own custom file seperate from SimpleEvents.java (e.g. EvtItem with its god awful return "dispense/spawn/drop/craft/pickup/consume/break/despawn/merge/move/stonecutting") which is pretty messy + bad overhaul for errors or whatever else toString is used for. Imagine having an issue with item drop event just to get e.g. "event-example cannot be used in an on dispense/spawn/drop/craft/pickup/consume/break/despawn/merge/move/stonecutting bedrock event" its messy and not great

Solution

Adds on to SimpleEvent which allows you to create a SimpleEvent("") so the usage would go something along in an event registry: .supplier(() -> new SimpleEvent("my super cool event")
if no value is provided it will default to using 'simple event' for the toString

Testing Completed

quicktest ran fine and no errors in intellij/conflicts so i'd say works

Supporting Information

small pr '-'

also credit to smurfy/sovde for the idea n code


Completes: none
Related: none
AI assistance: none

@AnOwlBe AnOwlBe requested review from a team, APickledWalrus and sovdeeth as code owners June 28, 2026 06:33
@skriptlang-automation skriptlang-automation Bot added needs reviews A PR that needs additional reviews needs triage An issue that hasn't been classified or verified yet labels Jun 28, 2026
@skriptlang-automation

This comment has been minimized.

@AnOwlBe AnOwlBe changed the base branch from master to dev/feature June 28, 2026 06:33
@skriptlang-automation skriptlang-automation Bot added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jun 28, 2026
@skriptlang-automation skriptlang-automation Bot removed the needs triage An issue that hasn't been classified or verified yet label Jun 28, 2026
@skriptlang-automation skriptlang-automation Bot moved this to In Review in 2.16 Releases Jun 28, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Merge in 2.16 Releases Jun 28, 2026
@skriptlang-automation skriptlang-automation Bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Jun 28, 2026
@sovdeeth sovdeeth force-pushed the ToStringForSimpleEvent branch from 1c65967 to e36f45d Compare June 28, 2026 17:42
@sovdeeth sovdeeth merged commit 9a34a62 into SkriptLang:dev/feature Jun 28, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Awaiting Merge to Done - Awaiting Release in 2.16 Releases Jun 28, 2026
@skriptlang-automation skriptlang-automation Bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.

Projects

Status: Done - Awaiting Release

Development

Successfully merging this pull request may close these issues.

3 participants