This repository was archived by the owner on Aug 12, 2025. It is now read-only.
Add cache times to credentials.json#2277
Merged
Shiiyu merged 6 commits intoSkyCryptWebsite:developmentfrom Sep 26, 2024
Merged
Conversation
Shiiyu
approved these changes
Sep 26, 2024
Member
Shiiyu
left a comment
There was a problem hiding this comment.
lgtm, yet to test, will do tomorrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds configurable cache times (in seconds) to the credentials file.
While I don't really think the credentials file is a great place for this, there's not really a better spot and this functionality definitely needed to go somewhere.
I also added a
cachetimes.jsfile which exports helper functions to check if a cache on a specific resource is expired. These functions are then used to make the cache checks inlib.jsmuch easier to understand.Default cache times might want to be changed, there were some very confusing checks that I replaced with this PR, so make sure to double-check those.
Right now they're defined in the credentials file like this: