Skip to content
This repository was archived by the owner on Aug 12, 2025. It is now read-only.

fix: hotm#2287

Merged
Shiiyu merged 2 commits intoSkyCryptWebsite:developmentfrom
averithefox:fixes
Oct 15, 2024
Merged

fix: hotm#2287
Shiiyu merged 2 commits intoSkyCryptWebsite:developmentfrom
averithefox:fixes

Conversation

@averithefox
Copy link
Copy Markdown
Contributor

@averithefox averithefox commented Oct 12, 2024

Fixes #2273, Fixes #2263

Fixed HOTM tree, broken by the mining update

@DuckySoLucky
Copy link
Copy Markdown
Member

Well- there goes all @Shiiyu work :kek:

@Shiiyu
Copy link
Copy Markdown
Member

Shiiyu commented Oct 13, 2024

Well- there goes all @Shiiyu work :kek:

I only had HOTM 10 left and was going to finish this morning, but you beat me to it haha.

Though you did reformat things in a way similar to how I did things, I see some minor changes and some other small things I'll end up changing before this pr would potentially be merged, although it's only a small concern.

The big issue is that you've changed the packages, especially because it's in a way that things won't actually run at all due to rollup erroring. I am also unsure why the gitignore was changed either when it shouldn't have. These things need to be reverted.

Lastly, please move the dragon changes to a separate pr.

Once these things are done, I'll make the few minor changes to hotm and then get your pr through.

Copy link
Copy Markdown
Member

@Shiiyu Shiiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix these things before the pr is reconsidered

… Core of the Mountain logic to accumulate awards
@Shiiyu
Copy link
Copy Markdown
Member

Shiiyu commented Oct 15, 2024

Somehow managed to revert to an older commit when trying to pull origin 😭

@Shiiyu Shiiyu merged commit 198981c into SkyCryptWebsite:development Oct 15, 2024
@averithefox averithefox deleted the fixes branch October 15, 2024 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HotM Tree shows wrong HoTM tree

3 participants