refactor(bpk-component-list): migrate to TypeScript#4196
Merged
Gert-Jan Vercauteren (gert-janvercauteren) merged 6 commits intomainfrom Feb 3, 2026
Merged
Conversation
- Convert BpkList.js to BpkList.tsx - Replace Flow types with TypeScript types - Remove PropTypes in favor of TypeScript Props type - Export Props type for consumers Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Convert BpkListItem.js to BpkListItem.tsx - Replace Flow types with TypeScript types - Remove PropTypes in favor of TypeScript Props type - Export Props type for consumers Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Convert test files from .js to .tsx - Remove Flow type annotations - Update snapshot file names Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Convert index.js to index.ts - Add type exports for BpkListProps and BpkListItemProps Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the bpk-component-list package from JavaScript/Flow to TypeScript, modernizing the type system while maintaining functionality and test coverage.
Changes:
- Converted component files from Flow to TypeScript with proper type definitions
- Exported component Props types for consumer usage
- Removed Flow annotations from all test files
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
index.ts |
Added TypeScript type exports for BpkListProps and BpkListItemProps |
BpkList.tsx |
Converted from Flow to TypeScript, removed PropTypes, improved variable naming |
BpkListItem.tsx |
Converted from Flow to TypeScript, removed PropTypes validation |
BpkList-test.tsx |
Removed Flow annotation |
BpkListItem-test.tsx |
Removed Flow annotation |
accessibility-test.tsx |
Removed Flow annotation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Gert-Jan Vercauteren (gert-janvercauteren)
added
patch
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Visit https://backpack.github.io/storybook-prs/4196 to see this build running in a browser. |
- Make ordered prop optional (has default value) - Change ariaLabel, ariaLabelledby, title to string | undefined (compatible with HTML attribute types) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Visit https://backpack.github.io/storybook-prs/4196 to see this build running in a browser. |
IrinaWei
reviewed
Feb 2, 2026
| import BpkList from './src/BpkList'; | ||
| import BpkListItem from './src/BpkListItem'; | ||
|
|
||
| export type { Props as BpkListProps } from './src/BpkList'; |
Contributor
There was a problem hiding this comment.
Maybe there could be export type BpkListProps directly if the name Props is changed to BpkListProps in BpkList.tsx, but it's not an issue
IrinaWei
approved these changes
Feb 3, 2026
Gert-Jan Vercauteren (gert-janvercauteren)
merged commit 7daec19
into
main
13 checks passed
Gert-Jan Vercauteren (gert-janvercauteren)
deleted the
gert-janvercauteren/js-to-ts-migration
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bpk-component-listpackage from JavaScript/Flow to TypeScriptBpkListandBpkListItemcomponents to TypeScriptBpkListProps,BpkListItemProps)Changes
index.js→index.tsBpkList.js→BpkList.tsxBpkListItem.js→BpkListItem.tsx.tsx, removed Flow annotationsTest plan
npm run jest -- packages/bpk-component-list)🤖 Generated with Claude Code