[NO JIRA][BpkSegmentedControl] Fix transpile error#4283
Merged
Ezreal Yang (Supremeyh) merged 1 commit intomainfrom Mar 16, 2026
Merged
[NO JIRA][BpkSegmentedControl] Fix transpile error#4283Ezreal Yang (Supremeyh) merged 1 commit intomainfrom
Ezreal Yang (Supremeyh) merged 1 commit intomainfrom
Conversation
Faye (Faye-Xiao)
approved these changes
Mar 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates BpkSegmentedControlV2 to avoid a build/transpile failure by switching the Ark UI SegmentGroup import to the package root entrypoint.
Changes:
- Replace
@ark-ui/react/segment-groupsubpath import with@ark-ui/reactimport forSegmentGroup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Visit https://backpack.github.io/storybook-prs/4283 to see this build running in a browser. |
Richard-Shen (RichardSyq)
pushed a commit
that referenced
this pull request
Mar 18, 2026
Switch @ark-ui/react/checkbox subpath import to @ark-ui/react root entrypoint to fix transpile:dts failure. Same fix as #4283 for SegmentedControlV2. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Richard-Shen (RichardSyq)
added a commit
that referenced
this pull request
Mar 18, 2026
* [NO JIRA][BpkCheckboxV2] Fix transpile error by using root ark-ui import Switch @ark-ui/react/checkbox subpath import to @ark-ui/react root entrypoint to fix transpile:dts failure. Same fix as #4283 for SegmentedControlV2. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove unnecessary CheckboxCheckedChangeDetails type annotation The implicit any error was a cascade from the unresolved subpath import. With the root import fixed, TS can infer the details type correctly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Richard Shen <richardshen@skyscanner.net> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
BpkSegmentedControlV2to avoid a transpilenpm run transpilefailure by switching the Ark UISegmentGroupimport to the package root entrypoint.Changes:
@ark-ui/react/segment-groupsubpath import with@ark-ui/reactimport forSegmentGroup.Remember to include the following changes:
[Clover-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md