Skip to content

[NO JIRA][BpkSegmentedControl] Fix transpile error#4283

Merged
Ezreal Yang (Supremeyh) merged 1 commit intomainfrom
cl/no-jira_fix_transpile_error
Mar 16, 2026
Merged

[NO JIRA][BpkSegmentedControl] Fix transpile error#4283
Ezreal Yang (Supremeyh) merged 1 commit intomainfrom
cl/no-jira_fix_transpile_error

Conversation

@Supremeyh
Copy link
Contributor

@Supremeyh Ezreal Yang (Supremeyh) commented Mar 16, 2026

Updates BpkSegmentedControlV2 to avoid a transpile npm run transpile failure by switching the Ark UI SegmentGroup import to the package root entrypoint.

Changes:

  • Replace @ark-ui/react/segment-group subpath import with @ark-ui/react import for SegmentGroup.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copilot AI review requested due to automatic review settings March 16, 2026 06:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates BpkSegmentedControlV2 to avoid a build/transpile failure by switching the Ark UI SegmentGroup import to the package root entrypoint.

Changes:

  • Replace @ark-ui/react/segment-group subpath import with @ark-ui/react import for SegmentGroup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/4283 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 7676cce

@Supremeyh Ezreal Yang (Supremeyh) merged commit 73b4732 into main Mar 16, 2026
21 checks passed
@Supremeyh Ezreal Yang (Supremeyh) deleted the cl/no-jira_fix_transpile_error branch March 16, 2026 06:28
Richard-Shen (RichardSyq) pushed a commit that referenced this pull request Mar 18, 2026
Switch @ark-ui/react/checkbox subpath import to @ark-ui/react root
entrypoint to fix transpile:dts failure. Same fix as #4283 for
SegmentedControlV2.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Richard-Shen (RichardSyq) added a commit that referenced this pull request Mar 18, 2026
* [NO JIRA][BpkCheckboxV2] Fix transpile error by using root ark-ui import

Switch @ark-ui/react/checkbox subpath import to @ark-ui/react root
entrypoint to fix transpile:dts failure. Same fix as #4283 for
SegmentedControlV2.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Remove unnecessary CheckboxCheckedChangeDetails type annotation

The implicit any error was a cascade from the unresolved subpath import.
With the root import fixed, TS can infer the details type correctly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Richard Shen <richardshen@skyscanner.net>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai: claude patch Patch production bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants