Install script improvements. #223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The script fails because the CI VMs do not have the permissions to /usr/local, but they have sudo permissions. They all try to copy and fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now offers the user if they only want to use a package, install from release, or build from source. Default behavior remains the same when no flags are passed.
There are more print outs to tell the user what is happening, and functions to conveniently print those colored readouts (success, warning, failure => green, yellow, red text).
Hoping to improve the installation by adding install prefix customization, and reduce the amount of "sudos".
Its worth taking a look at if you don't want to pull, I added some cool features.