Skip to content

Conversation

@geirsagberg
Copy link
Contributor

We had a problem just like #22, seemingly due to hash collisions.

This PR expands the instance cache to use a Tuple with identifier hash, type hash and optional parent reference, to avoid any hash collisions.
Also:

  • Wrap hash arithmetic in unchecked to avoid arithmetic overflow
  • Make most types internal
  • Add optional parameter keepCache to Map and DynamicMap methods. This fixes issues we had when calling similar queries sequentially in same HttpContext, e.g. when grouping by a field it would aggregate the collection entries, so first query returned 10 children, second returned 20, third 30 etc.

@odelvalle odelvalle merged commit c7eacd3 into SlapperAutoMapper:master Feb 22, 2016
odelvalle added a commit that referenced this pull request Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants