Avoid hash collisions by including more keys #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem just like #22, seemingly due to hash collisions.
This PR expands the instance cache to use a
Tuplewith identifier hash, type hash and optional parent reference, to avoid any hash collisions.Also:
uncheckedto avoid arithmetic overflowkeepCachetoMapandDynamicMapmethods. This fixes issues we had when calling similar queries sequentially in same HttpContext, e.g. when grouping by a field it would aggregate the collection entries, so first query returned 10 children, second returned 20, third 30 etc.