Implement refresh rate toggle/override#55
Open
Stafil0 wants to merge 13 commits intoSliceCraft:masterfrom
Open
Implement refresh rate toggle/override#55Stafil0 wants to merge 13 commits intoSliceCraft:masterfrom
Stafil0 wants to merge 13 commits intoSliceCraft:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54
This was slightly out of scope, but I refactored the notification system. It’s mainly a naming refactor, so if you don’t like it, I can revert these changes.
Regarding the refresh rate: we agreed with Panzer to keep the option to set any refresh rate value for testing purposes, but to add notification + permanent overlay that shows the current refresh rate during a run. If it exceeds the 540 Hz threshold, the overlay will indicate that the run is invalid.
And I refactored the FPS toggles and added more precise controls so anyone can select the most comfortable FPS for the skip.