v0.1.1: fix external review findings (SL-010)#7
Merged
Conversation
Addresses the 2026-06-19 external review. Each fix ships with regression tests (33 total; green with PyYAML and with the stdlib fallback CI uses). validators.py: - #2 Windows/Linux path portability: OS-agnostic part checks (_norm_parts) for frozen-dir skip, the .git skip, and .github/workflows detection (was '/'-only substring matching → broke on Windows os.walk '\\'). - #3 topic-tags semantics: unconfigured --topic-taxonomy now SKIPPED (green), configured-but-missing is a clear hard error (was a confusing "skipped" that failed the build). - #4 frontmatter parser: uses PyYAML automatically when installed (robust: block scalars, nested, comments); documented stdlib subset + inline-comment handling as fallback. No dependency required. - #5 llm-ci-cost: strips YAML comments before the endpoint heuristic (no more false-positive on comments/docs); structural concurrency + on.pull_request checks via PyYAML when available (handles the on:->True YAML quirk); custom endpoint/proxy limitation documented. calibrate.py: - #6 propose_bands ignored its percentile inputs and returned fixed bands → split into canonical_bands() (fixed reference) + observed_bands(p) (genuinely data-driven from p25/p50/p75/p90); output now prints both, honestly labeled. - #7 percentiles used exclusive method (extrapolated past observed max on small samples) → inclusive + clamp to [min,max] + n==1 handling + small-sample (<8) advisory warning. #1 (counter-atomicity date-slug false-positive) was already fixed in v0.1.0 (toolkit#4) — the review ran the pre-fix 2026-06-19 snapshot. CI self-run upgraded to --checks all (topic-tags SKIPs cleanly now). New tests/test_calibrate.py adds the first calibration tests. Per DR-2026-06-19 (gates + tests for every fix). SL-010. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the valid findings from the 2026-06-19 external review, each with regression tests (33 total; green with PyYAML and the stdlib fallback CI uses).
_norm_parts)SKIPPED(green); configured-but-missing → hard errorconcurrency/on.pull_requestvia PyYAMLpropose_bandsignored percentilescanonical_bands()+ data-drivenobserved_bands(p)#1 (counter date-slug) was already fixed in v0.1.0 (the review ran the pre-fix snapshot). CI self-run upgraded to
--checks all.