Skip to content

Slash in partial names #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincent-psarga merged 2 commits into from
Oct 21, 2019
Merged

Slash in partial names #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e5e99e
Add test specs to support slash in partial names
d316 Oct 17, 2019
9855095
Add support for the forward slash in partial names
d316 Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/ruby-handlebars/parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class Parser < Parslet::Parser
rule(:as_kw) { str('as') }

rule(:identifier) { (else_kw >> space? >> dccurly).absent? >> match['@\-a-zA-Z0-9_\?'].repeat(1) }
rule(:directory) { (else_kw >> space? >> dccurly).absent? >> match['@\-a-zA-Z0-9_\/\?'].repeat(1) }
rule(:path) { identifier >> (dot >> (identifier | else_kw)).repeat }

rule(:nocurly) { match('[^{}]') }
Expand Down Expand Up @@ -96,7 +97,7 @@ class Parser < Parslet::Parser
docurly >>
gt >>
space? >>
identifier.as(:partial_name) >>
directory.as(:partial_name) >>
space? >>
dccurly
}
Expand Down
10 changes: 10 additions & 0 deletions spec/handlebars_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ def evaluate(template, args = {})
expect(evaluate("Hello {{> plic}}")).to eq("Hello Plic")
end

it 'using a name with a slash' do
hbs.register_partial('parent/plic', "Plic")
expect(evaluate("Hello {{> parent/plic}}")).to eq("Hello Plic")
end

it 'using a name that begins with a slash' do
hbs.register_partial('/parent/plic', "Plic")
expect(evaluate("Hello {{> /parent/plic}}")).to eq("Hello Plic")
end

it 'using context' do
hbs.register_partial('brackets', "[{{name}}]")
expect(evaluate("Hello {{> brackets}}", {name: 'world'})).to eq("Hello [world]")
Expand Down