Skip to content

Escape triple-brace replacements#9

Closed
schuetzm wants to merge 1 commit intoSmartBear:masterfrom
schuetzm:implement-escaping
Closed

Escape triple-brace replacements#9
schuetzm wants to merge 1 commit intoSmartBear:masterfrom
schuetzm:implement-escaping

Conversation

@schuetzm
Copy link
Copy Markdown
Contributor

@schuetzm schuetzm commented Apr 5, 2019

No description provided.

@schuetzm schuetzm mentioned this pull request Apr 8, 2019
Merged
@vincent-psarga
Copy link
Copy Markdown
Contributor

vincent-psarga commented Jun 20, 2019

Sorry I screwed up the merge :/
That said, I fixed it locally but some tests are failing (certainly due to other PRs I merged recently). I'll have a look at it tomorrow morning.

(and sorry for the time to check this PR)

@vincent-psarga vincent-psarga mentioned this pull request Jun 21, 2019
Merged
@schuetzm
Copy link
Copy Markdown
Contributor Author

schuetzm commented Jun 21, 2019

@vincent-psarga I've rebased this pull request, it should now merge cleanly. You can close the other one (#13). I'm also going to rebase my other PRs, if there are problems. Just ping me when you've merged this one. (And no need to be sorry, I know how it is when you're busy with lots of stuff...)

@vincent-psarga
Copy link
Copy Markdown
Contributor

vincent-psarga commented Jun 21, 2019

I've seeen your changes after the merge of the previous one sorry :/

In any case thanks a lot for your contribution 👍 (and the other ones I haven't fully checked yet but seem more than promising ;) )

This should be released today alongside the other PRs :)

@schuetzm schuetzm deleted the implement-escaping branch June 27, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@schuetzm @vincent-psarga