Add support for API v1.8 features callback and hostAndPort (run project)#28
Merged
RahulPundir83 merged 12 commits intoSmartBear:masterfrom Mar 26, 2021
Merged
Add support for API v1.8 features callback and hostAndPort (run project)#28RahulPundir83 merged 12 commits intoSmartBear:masterfrom
RahulPundir83 merged 12 commits intoSmartBear:masterfrom
Conversation
Feature/api18enhancements
Contributor
|
Hello @waxtell, Thank you for your time and effort. We will take a look into it soon.It may take some time |
|
@waxtell - We are reviewing your PR, mind fixing conflicts? |
This reverts commit b02deb3.
# Conflicts: # bin/run_functions.js # package.json
Contributor
Author
|
@akkikumar72 done and done! Thanks! |
brahmdev
reviewed
Mar 23, 2021
| { | ||
| "name": "testengine-cli", | ||
| "version": "1.5.0", | ||
| "version": "1.8.0", |
There was a problem hiding this comment.
imho, I think this should be 1.6.0 instead
Because the versioning of TestEngine API and TestEngine CLI are not in sync.
Contributor
Author
There was a problem hiding this comment.
Was wondering the same as well... happy to make the change.
akkikumar72
reviewed
Mar 23, 2021
akkikumar72
reviewed
Mar 23, 2021
akkikumar72
approved these changes
Mar 23, 2021
akkikumar72
left a comment
akkikumar72
left a comment
There was a problem hiding this comment.
@waxtell Good job, Thanks for your contribution.
RahulPundir83
suggested changes
Mar 25, 2021
RahulPundir83
approved these changes
Mar 26, 2021
Contributor
Author
|
Thank you very much @RahulPundir83, @bsubba, @akkikumar72 and @brahmdev! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I hope this
notePR finds you well!First and foremost, thank you very much for providing this tool. The tool is an integral component of my CI/CD process and I am truly grateful for your efforts.
Second, I apologize in advance for the unsolicited PR. I didn't want to create an issue and I could not locate "guidelines for contributing".
Prior to version 1.8 of the TestEngine API you could only specify environment - not endpoint. With version 1.8 the hostAndPort feature was added and provided a mechanism for routing test requests to a specific endpoint. My PR includes support for hostAndPort as well as callback.
Thank you again for your efforts and your consideration.
Best Regards,
Will