Merged
Conversation
DarkPurple141
added
Feature
NunoDasNeves
reviewed
Sep 2, 2018
| */ | ||
| exports.cors = function(_, response, next) { | ||
| response.header('Access-Control-Allow-Origin', '*') | ||
| response.header('Access-Control-Allow-Headers', 'Origin, X-Requested-With, Content-Type, Accept') |
Collaborator
There was a problem hiding this comment.
this cors thing just adds headers to the response?
Collaborator
Author
There was a problem hiding this comment.
Yep. In production we will possibly need cors as well, but configured to a specific origin.
Papa-au
reviewed
Sep 2, 2018
| next() | ||
| }) | ||
| app.use(logger('dev')) | ||
| app.use(require('./utils/cors').cors) |
Collaborator
There was a problem hiding this comment.
This is a good idea to differentiate dev and prod.
aruzal
approved these changes
Sep 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lots of things.