Some basic tests for answer route and model#123
Merged
DarkPurple141 merged 3 commits intodevfrom Sep 6, 2018
Merged
Conversation
DarkPurple141
requested changes
Sep 6, 2018
Collaborator
DarkPurple141
left a comment
DarkPurple141
left a comment
There was a problem hiding this comment.
Also these are all in the wrong file. They're testing the routes. See routes folder for this sort of testing.
| .set('Accept', 'application/json') | ||
| .expect('Content-Type', /json/) | ||
| .expect(400) | ||
| .then(response => { |
Collaborator
There was a problem hiding this comment.
looks like body does actually exist.
backend/tests/routes/questions.js
Outdated
| .expect('Content-Type', /json/) | ||
| .expect(200) | ||
| .then(response => { | ||
| assert(response.body.length === 2) |
Collaborator
There was a problem hiding this comment.
change to two separate tests described as in slack. (two asserts implies two it's)
DarkPurple141
requested changes
Sep 6, 2018
| const expect = chai.expect | ||
|
|
||
| /* TODO build out tests to also include catching expected JSON response */ | ||
| describe('Question route testing', () => { |
Collaborator
There was a problem hiding this comment.
Thus should still exist.
Collaborator
There was a problem hiding this comment.
Wrapping what you've done below.
Collaborator
Author
|
ok review plz |
DarkPurple141
approved these changes
Sep 6, 2018
| const app = require('../../src') | ||
| const supertest = require('supertest')(app) | ||
| const chai = require('chai') | ||
| const expect = chai.expect |
Collaborator
There was a problem hiding this comment.
can be:
const { expect } = require('chai')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.