Skip to content

Delete buttons#330

Merged
NunoDasNeves merged 15 commits intodevfrom
delete-post-buttons
Jan 28, 2019
Merged

Delete buttons#330
NunoDasNeves merged 15 commits intodevfrom
delete-post-buttons

Conversation

@NunoDasNeves
Copy link
Collaborator

@NunoDasNeves NunoDasNeves commented Jan 26, 2019

Needs prettifying and critique.

  • meta field with canDelete, canEdit is now passed by the backend on requests for all kind of posts (comments, questions, reviews)
  • due to this (and for future similar issues with refreshing the page etc) there is a thing in the router which will block on boot until checkAuth is completed. A slightly more refined version of this may be needed, but it might be okay for now (a better version would show the loading circle during checkAuth, and allow requests that really don't need auth)
  • working delete buttons for all kinds of posts with confirm() cos deleting is a big deal. Button should be moved to triple dot menu thing and made pretty
  • no edit functionality yet, but most of the infrastructure is there in the store, i think save it for a future PR
  • thoughts on delete/edit buttons being in course feeds? At the moment it's just in Question and Review views.
  • some bugfixes and random improvements included
  • thoughts on mass delete/edit/something interface? moderation interface showing reported posts to review?

@coveralls
Copy link

coveralls commented Jan 26, 2019

Pull Request Test Coverage Report for Build 1454

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.3%) to 87.189%

Files with Coverage Reduction New Missed Lines %
src/models/question.js 1 78.43%
src/models/review.js 1 75.0%
src/utils/error.js 3 72.22%
src/controllers/question.js 4 89.83%
src/controllers/review.js 8 82.46%
src/utils/helpers.js 8 80.65%
Totals Coverage Status
Change from base Build 1432: -0.3%
Covered Lines: 763
Relevant Lines: 824

💛 - Coveralls

DarkPurple141
DarkPurple141 previously approved these changes Jan 27, 2019
Copy link
Collaborator

@DarkPurple141 DarkPurple141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, see comments.

@DarkPurple141
Copy link
Collaborator

DarkPurple141 commented Jan 27, 2019

  • thoughts on delete/edit buttons being in course feeds? At the moment it's just in Question and Review views.

I think for now, not.

  • thoughts on mass delete/edit/something interface? moderation interface showing reported posts to review?

This is a good idea. Wondering if backend should employ sqlserver triggers for delete.

Copy link
Collaborator

@DarkPurple141 DarkPurple141 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@NunoDasNeves NunoDasNeves merged commit faf2edd into dev Jan 28, 2019
@NunoDasNeves NunoDasNeves deleted the delete-post-buttons branch January 28, 2019 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants