Merged
Conversation
Pull Request Test Coverage Report for Build 1622
💛 - Coveralls |
NunoDasNeves
reviewed
Feb 9, 2019
| // will be reused, and this hook will be called when that happens. | ||
| // has access to `this` component instance. | ||
| if (this.code && this.code !== code) { | ||
| // BUG as far as I'm aware this is only called |
Collaborator
There was a problem hiding this comment.
i think this fixed a bug where data was sticking between coursesss... but if that's happening again...
Collaborator
Author
There was a problem hiding this comment.
Doesn’t seem to be doing anything.
Collaborator
Author
There was a problem hiding this comment.
The data isn’t sticking anyway; it’s the api that’s not wkrking
NunoDasNeves
approved these changes
Feb 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.