Delta update preliminary version#11
Merged
yiiyama merged 2 commits intoSmartDataProjects:productionfrom Oct 13, 2017
dr-stringfellow:production
Merged
Delta update preliminary version#11yiiyama merged 2 commits intoSmartDataProjects:productionfrom dr-stringfellow:production
yiiyama merged 2 commits intoSmartDataProjects:productionfrom
dr-stringfellow:production
Conversation
yiiyama
reviewed
Oct 13, 2017
| sites = list(set([r.site for r in replica_list])) # list of sites | ||
| datasets = list(set([r.block.dataset for r in replica_list])) # list of datasets | ||
| groups = list(set([r.block.group for r in replica_list])) # list of groups | ||
| # Load all groups - otherwise it won't pass obj.name in the make_map function if group == None. |
Collaborator
There was a problem hiding this comment.
This will create new group objects, so in general block_id_map[replica.block] will crash with KeyError.
yiiyama
approved these changes
Oct 13, 2017
Collaborator
yiiyama
left a comment
yiiyama
left a comment
There was a problem hiding this comment.
As written in the comment, the new function can crash in general cases, but with our use case we are fine. To be updated in the next patch release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All checks have been completed.