Not considering replicas for deletions if on certain site#22
Merged
dr-stringfellow merged 4 commits intoSmartDataProjects:productionfrom Nov 24, 2017
yiiyama:production
Merged
Not considering replicas for deletions if on certain site#22dr-stringfellow merged 4 commits intoSmartDataProjects:productionfrom yiiyama:production
dr-stringfellow merged 4 commits intoSmartDataProjects:productionfrom
yiiyama:production
Conversation
Collaborator
There was a problem hiding this comment.
Would it make more sense to introduce after l.107 in the main.py:
replica.dataset.demand['on_protected_site'] = False
and then replace l.109 with:
if not replica.dataset.demand['on_protected_site']:
replica.dataset.demand['on_protected_site'] = self.inventory_manager.store.check_if_on(ds_name,site name)
I am not sure what happens with datasets for which the demand variable is not filled ...
Collaborator
Author
|
No worries, in variables.py we place the evaluation of the flag under a try block, so having datasets without on_protected_site is not a problem. |
dr-stringfellow
approved these changes
Nov 24, 2017
Collaborator
dr-stringfellow
left a comment
dr-stringfellow
left a comment
There was a problem hiding this comment.
True, missed that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picked up #21. Result of a test run is at http://t3desk007.mit.edu/dynamo/detoxtest.php?cycleNumber=10835. If you open some large site and search for
protected_siteyou find some datasets protected because they are on a protected site (i.e. CNAF MSS).