Update sdl_android to 5.4.0 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up metadata in AndroidManifest.xml Add BLUETOOTH_CONNECT permission to AndroidManifest.xml Fix LocationPermissionHelper.getNewestInstance() always returning null Add direct Bluetooth permission request to MainActivity Add PendingIntent to SdlReceiver to use an existing router service if available
JulianKast
requested changes
Jun 1, 2022
Contributor
There was a problem hiding this comment.
Overall review of the app, looks good. a few changes are necessary, In SdlService I would change :
override fun onStartCommand(intent: Intent, flags: Int, startId: Int): Int {
to
override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
Also, I don't see the benefit of using Factory Pattern as the library already uses the builder pattern to build SdlManager.
JulianKast
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up metadata in AndroidManifest.xml
Add BLUETOOTH_CONNECT permission to AndroidManifest.xml
Fix LocationPermissionHelper.getNewestInstance() always returning null
Add direct Bluetooth permission request to MainActivity
Add PendingIntent to SdlReceiver to use an existing router service if available