Feature/Convert to Android Studio project and other miscellaneous updates #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
April 11, 2018 16:54
bilal-alsharifi
changed the title
BrettyWhite
approved these changes
Apr 13, 2018
joeygrover
reviewed
Apr 16, 2018
| package="com.ford.mobileweather" | ||
| android:versionCode="26" | ||
| android:versionName="1.7.14 " > | ||
| package="com.ford.mobileweather"> |
There was a problem hiding this comment.
I think we should rename this package, and thus all the code packages as well. com.sdl.mobileweather should work fine.
There was a problem hiding this comment.
Sure, I will update the package name to com.sdl.mobileweather.
joeygrover
reviewed
Apr 16, 2018
| <service android:name="com.ford.mobileweather.noaa.NOAAService" > | ||
| </service> | ||
| <!--<service android:name="com.ford.mobileweather.noaa.NOAAService" >--> | ||
| <!--</service>--> |
There was a problem hiding this comment.
Is there a reason this is commented out?
There was a problem hiding this comment.
Not really :) I will just remove it completely.
joeygrover
reviewed
Apr 16, 2018
| @@ -1,7 +1,6 @@ | |||
| package com.ford.mobileweather.activity; | |||
There was a problem hiding this comment.
The onCreate method should include the call to SmartDeviceLinkReceiver.queryForConnectedService(this);
joeygrover
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.