BUG2-2243 Add composite display to zigbee humidity sensors#1586
Merged
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 61 files ± 0 375 suites ±0 0s ⏱️ ±0s Results for commit 0e2f661. ± Comparison against base commit 5bd9bbd. This pull request removes 5 tests.♻️ This comment has been updated with latest results. |
|
matter-sensor_coverage.xml
zigbee-humidity-sensor_coverage.xml
zwave-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0e2f661 |
Seong-Yeol-Park
approved these changes
Aug 19, 2024
Contributor
Seong-Yeol-Park
left a comment
Seong-Yeol-Park
left a comment
There was a problem hiding this comment.
It looks good to me.
| version: 1 | ||
| values: | ||
| - label: " {{humidity.value}} {{humidity.unit}}" | ||
| composite: true No newline at end of file |
Contributor
There was a problem hiding this comment.
no newline at a end of file
greens
changed the title
bflorian
reviewed
Aug 20, 2024
| explicit: true | ||
| - preferenceId: humidityOffset | ||
| explicit: true | ||
| config: |
Contributor
There was a problem hiding this comment.
The root level property name has to be deviceConfig. Also, until CODA-3870 has been implemented, the device config has to contain all of the sections, i.e. detailView and automation. Same comment for the other files
Contributor
Seong-Yeol-Park
left a comment
Seong-Yeol-Park
left a comment
There was a problem hiding this comment.
@greens I'm sorry for confusing you with the wrong example.
I added suggestions for corrections.
Contributor
Seong-Yeol-Park
left a comment
Seong-Yeol-Park
left a comment
There was a problem hiding this comment.
Could you also remove these lines?
As far as I know, when we use root deviceConfig, embed config shouldn't be used.
Thank you!
Contributor
Seong-Yeol-Park
left a comment
Seong-Yeol-Park
left a comment
There was a problem hiding this comment.
All changes looks good to me.
But it seems like that removing these lines is missing.
a2881ef#diff-3d8741588a39d2231d633a95fa58fa4445e6755677944b2bb6ac0a4811243e46R7-R10
Updates profile to show both temperature and humidity on the device card for zigbee humidity/temperature sensors.
greens
force-pushed
the
feature/BUG-2243
branch
from
38fff6f to
0e2f661
Compare
bflorian
approved these changes
Aug 27, 2024
Contributor
|
Heads up that this change breaks some unit tests, because the added yaml for the profiles, despite being valid yaml is not able to be parsed by our lua libs yaml parser for the profiles. |
12 tasks
Contributor
Author
|
@cjswedes Ah. I guess since it was only yaml changes the unit tests didn't run. I can work on implementing a fix here. |
Contributor
|
@greens Could you let me know when this PR will be deployed to the production? |
Contributor
Author
|
@Seong-Yeol-Park later this week. Thursday in Korea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates profile to show both temperature and humidity on the device card for zigbee humidity/temperature sensors.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests