Skip to content

New Device (Matter Thermostat) Bosch Radiator Thermostat II [+M] #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
greens merged 4 commits into from
Apr 9, 2025
Merged

New Device (Matter Thermostat) Bosch Radiator Thermostat II [+M] #2020

greens merged 4 commits into from
Apr 9, 2025

Conversation

@lelandblue
Copy link
Contributor

@lelandblue lelandblue commented Mar 25, 2025

Check all that apply

Type of Change

  • [ X] WWST Certification Request
  • Bug fix
  • New feature
  • Refactor

Checklist

  • [ X] I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding a fingerprint for a Bosch Device
VID: 0x1209
PID: 0x3012
Matter Device Type ID: 0x301

Summary of Completed Tests

@github-actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

Channel deleted.

@github-actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

Test Results

   66 files    420 suites   0s ⏱️
2 164 tests 2 164 ✅ 0 💤 0 ❌
3 685 runs  3 685 ✅ 0 💤 0 ❌

Results for commit 2d80b19.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

File Coverage
All files 84% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 48% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 86% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 2d80b19

nickolas-deboom
nickolas-deboom reviewed Mar 26, 2025
View reviewed changes
@greens greens merged commit 137eef2 into main Apr 9, 2025
11 checks passed
@greens greens deleted the new-device-bosch branch April 9, 2025 20:54
greens pushed a commit that referenced this pull request Apr 14, 2025
@lelandblue @hcarter-775 @greens
New Device (Matter Thermostat) Bosch Radiator Thermostat II [+M] (#2020)
aab857d 
* Adding Bosch Radiator Thermo II M fingerprint

* Update fingerprints.yml

---------

Co-authored-by: Harrison Carter <137556605+hcarter-775@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hcarter-775 hcarter-775 hcarter-775 approved these changes

@nickolas-deboom nickolas-deboom nickolas-deboom approved these changes

@z-michel z-michel Awaiting requested review from z-michel

Assignees

No one assigned

Labels

do not merge WWST

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lelandblue @hcarter-775 @nickolas-deboom @greens