Skip to content

Conversation

@nickolas-deboom
Copy link
Contributor

@nickolas-deboom nickolas-deboom commented Jun 4, 2025

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor
  • New profile

Description of Change

Adding new profiles for thermostats with no battery after support for thermostatOperatingState was added. Previously, devices would use thermostat-heating-only-nostate-nobattery (for example) whether or not they supported ThermostatRunningState.

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Channel deleted.

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Test Results

   67 files  ±0    440 suites  ±0   0s ⏱️ ±0s
2 250 tests ±0  2 250 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 841 runs  ±0  3 841 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fab64d2. ± Comparison against base commit 634161b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jun 4, 2025

File Coverage
All files 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 95%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against fab64d2

@nickolas-deboom nickolas-deboom changed the title Add thermostat-heating-only-nobattery profile Add new profiles including thermostatOperatingState Jun 4, 2025
@nickolas-deboom nickolas-deboom force-pushed the matter-thermostat-add-thermostat-heating-only-nobattery-profile branch from 6b5befc to ac346f4 Compare June 4, 2025 17:58
@ldeora
Copy link

ldeora commented Jun 4, 2025

What about thermostat-heating-only-nostate-nobattery?

@nickolas-deboom
Copy link
Contributor Author

What about thermostat-heating-only-nostate-nobattery?

This profile exists already, see here

Adding new profiles for thermostats with no battery after support for thermostatOperatingState was added. Previously, devices would use `thermostat-heating-only-nostate-nobattery` (for example) whether or not they supported ThermostatRunningState.
@nickolas-deboom nickolas-deboom force-pushed the matter-thermostat-add-thermostat-heating-only-nobattery-profile branch from ac346f4 to fab64d2 Compare June 4, 2025 18:26
@nickolas-deboom nickolas-deboom merged commit 9db4783 into main Jun 4, 2025
12 checks passed
@nickolas-deboom nickolas-deboom deleted the matter-thermostat-add-thermostat-heating-only-nobattery-profile branch June 4, 2025 20:54
dljsjr pushed a commit that referenced this pull request Jun 9, 2025
Adding new profiles for thermostats with no battery after support for thermostatOperatingState was added. Previously, devices would use `thermostat-heating-only-nostate-nobattery` (for example) whether or not they supported ThermostatRunningState.
dljsjr pushed a commit that referenced this pull request Jun 9, 2025
Adding new profiles for thermostats with no battery after support for thermostatOperatingState was added. Previously, devices would use `thermostat-heating-only-nostate-nobattery` (for example) whether or not they supported ThermostatRunningState.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants