Skip to content

Keep SUPPORTED_COMPONENT_CAPABILITIES table on driver #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

Keep SUPPORTED_COMPONENT_CAPABILITIES table on driver #2448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,15 +439,10 @@ local function driver_switched(driver, device)
end

local function device_init(driver, device)
if device:get_field(SUPPORTED_COMPONENT_CAPABILITIES) then
if version.api >= 15 and version.rpc >= 9 then
-- the device used this modular profile workaround on 0.57 FW but no longer requires this table with >=0.58 FW
device:set_field(SUPPORTED_COMPONENT_CAPABILITIES, nil)
else
-- assume that device is using a modular profile on 0.57 FW, override supports_capability_by_id
-- library function to utilize optional capabilities
device:extend_device("supports_capability_by_id", supports_capability_by_id_modular)
end
if device:get_field(SUPPORTED_COMPONENT_CAPABILITIES) and (version.api < 15 or version.rpc < 9) then
-- assume that device is using a modular profile on 0.57 FW, override supports_capability_by_id
-- library function to utilize optional capabilities
device:extend_device("supports_capability_by_id", supports_capability_by_id_modular)
end
device:subscribe()
end
Expand Down
13 changes: 4 additions & 9 deletions drivers/SmartThings/matter-thermostat/src/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,15 +431,10 @@ local endpoint_to_component = function (device, endpoint_id)
end

local function device_init(driver, device)
if device:get_field(SUPPORTED_COMPONENT_CAPABILITIES) then
if version.api >= 15 and version.rpc >= 9 then
-- the device used this modular profile workaround on 0.57 FW but no longer requires this table with >=0.58 FW
device:set_field(SUPPORTED_COMPONENT_CAPABILITIES, nil)
else
-- assume that device is using a modular profile on 0.57 FW, override supports_capability_by_id
-- library function to utilize optional capabilities
device:extend_device("supports_capability_by_id", supports_capability_by_id_modular)
end
if device:get_field(SUPPORTED_COMPONENT_CAPABILITIES) and (version.api < 15 or version.rpc < 9) then
-- assume that device is using a modular profile on 0.57 FW, override supports_capability_by_id
-- library function to utilize optional capabilities
device:extend_device("supports_capability_by_id", supports_capability_by_id_modular)
end
device:subscribe()
device:set_component_to_endpoint_fn(component_to_endpoint)
Expand Down
Loading