Matter Thermostat: Re-organize the directory structure #2548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcarter-775
requested review from
cjswedes,
ctowns,
gharveymn,
greens and
nickolas-deboom
|
Channel deleted. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 56ec681 |
Contributor
|
I'm not seeing the functions you mentioned in |
hcarter-775
commented
Nov 12, 2025
drivers/SmartThings/matter-thermostat/src/thermostat_utils/device_configuration.lua
Show resolved
Hide resolved
greens
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Similar to the updates to Matter Switch: #2401 and Matter Sensor: #2521 .
This re-organizes the Matter Thermpstat driver to be more easily understandable and developer friendly.
I also updated the copyrights to the new shortened versions.
Note:
In making these changes on this PR, I have slightly re-worked the modular profile gating logic to make it "primary" over the static profile gating. The logic should be identical, but the
is_modular_profile_supportedhelper function and the mainmatch_profileentry function that used to exist have been consolidated into the now generalmatch_profilefunction in the newdevice_configuration.luafile and were thus removed. If anything, I would pay special attention to this particular bit of logic.Summary of Completed Tests
Unit tests all continue to pass, ensuring general functions remain intact. Like with the other PRs, I have manually ensured that each moved field and util function is appropriately linked to its associated function through VS code smart-linking.
Embedded clusters have been tested by running unit tests on old lua libs and ensuring that expected functionality is intact.
Tested with the following VDA devices: