Fix webrtc capability inclusion requirements #2568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the matter camera subdriver, the webrtc capability should be included if the `WebRTCTransportProvider` clusters is implemented as `SERVER` and if `WebRTCTransportRequestor` is implemented as `CLIENT`; this commit adds a check for the former which is currently missing from the subdriver.
|
Channel deleted. |
Test Results 71 files 469 suites 0s ⏱️ Results for commit 695c035. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 695c035 |
samadDotDev
approved these changes
Nov 19, 2025
ctowns
approved these changes
Nov 19, 2025
nickolas-deboom
deleted the
matter-camera-fix-webrtc-capability-inclusion
branch
hcarter-775
pushed a commit
that referenced
this pull request
Nov 20, 2025
In the matter camera subdriver, the webrtc capability should be included if the `WebRTCTransportProvider` clusters is implemented as `SERVER` and if `WebRTCTransportRequestor` is implemented as `CLIENT`; this commit adds a check for the former which is currently missing from the subdriver.
hcarter-775
added a commit
that referenced
this pull request
Nov 20, 2025
hcarter-775
pushed a commit
that referenced
this pull request
Nov 20, 2025
In the matter camera subdriver, the webrtc capability should be included if the `WebRTCTransportProvider` clusters is implemented as `SERVER` and if `WebRTCTransportRequestor` is implemented as `CLIENT`; this commit adds a check for the former which is currently missing from the subdriver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the matter camera subdriver, the webrtc capability should be included if the
WebRTCTransportProviderclusters is implemented asSERVERand ifWebRTCTransportRequestoris implemented asCLIENT; this commit adds a check for the former which is currently missing from the subdriver.