Main -> Beta: Hotfix 11-20-25: Matter Camera fix #2571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the matter camera subdriver, the webrtc capability should be included if the `WebRTCTransportProvider` clusters is implemented as `SERVER` and if `WebRTCTransportRequestor` is implemented as `CLIENT`; this commit adds a check for the former which is currently missing from the subdriver.
hcarter-775
requested review from
ctowns,
greens,
nickolas-deboom and
samadDotDev
|
Channel deleted. |
Test Results 71 files 468 suites 0s ⏱️ Results for commit b031f29. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against b031f29 |
nickolas-deboom
approved these changes
Nov 20, 2025
ctowns
approved these changes
Nov 20, 2025
tpmanley
reviewed
Nov 20, 2025
|
|
||
| local camera_endpoints = switch_utils.get_endpoints_by_device_type(device, fields.DEVICE_TYPE_ID.CAMERA) | ||
| if #camera_endpoints > 0 then | ||
| if #device:get_endpoints(clusters.WebRTCTransportProvider.ID, {cluster_type = "SERVER"}) > 0 and |
Contributor
There was a problem hiding this comment.
Why is this check here instead of just on the camera endpoint?
Contributor
There was a problem hiding this comment.
We wanted to enforce the cluster types here for WebRTCTransportProvider as SERVER and WebRTCTransportRequestor as CLIENT, which is why this check was moved out of the loop. Note that each device type (except for Camera Controller, which is not currently supported by the subdriver anyways) that includes WebRTCTransportProvider / WebRTCTransportRequestor also includes CameraAVStreamManagement as a mandatory cluster, so this check as it is currently should be sufficient for now.
This will be improved by #2570, which will check the cluster type for the other clusters as well and also moves the WebRTCTransport check back. I'd like to get more testing done on that PR which is why it wasn't included in this hotfix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: In the matter camera subdriver, the webrtc capability should be included if the
WebRTCTransportProviderclusters is implemented asSERVERand ifWebRTCTransportRequestoris implemented asCLIENT; this commit adds a check for the former which is currently missing from the subdriver.Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests