Skip to content

Conversation

@greens
Copy link
Contributor

@greens greens commented Nov 24, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

Channel deleted.

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

Test Results

   71 files    469 suites   0s ⏱️
2 457 tests 2 457 ✅ 0 💤 0 ❌
4 177 runs  4 177 ✅ 0 💤 0 ❌

Results for commit 06b185c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

File Coverage
All files 86%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sensor_handlers/attribute_handlers.lua 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/device_configuration.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/init.lua 80%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/fields.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/air_quality_sensor/legacy_device_configuration.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sensor_utils/embedded_cluster_utils.lua 45%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sensor_utils/device_configuration.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/bosch_button_contact/init.lua 85%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/sub_drivers/smoke_co_alarm/init.lua 83%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 06b185c

deviceLabel: Smart Presence Sensor (Thread)
vendorId: 0x1345
productId: 0x4202
deviceProfileName: matter-motion-battery-illuminance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that motion-illuminance-battery would be preferred, since this is what the driver will actually profile to. However, it doesn't really make a difference since they have the same capabilities. Do you have an opinion @hcarter-775 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah let's not use this profile. I missed this in my earlier audit of profiles marked for deprecation

@greens greens merged commit c0f12f8 into main Nov 26, 2025
11 checks passed
@greens greens deleted the new_device/WWSTCERT-9105 branch November 26, 2025 18:44
greens added a commit that referenced this pull request Dec 1, 2025
* WWSTCERT-9105 Meross Smart Presence Sensor (Thread)

* use non-deprecated profile

* use correct profile name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants