CHAD-17068: zigbee-humidity-sensor lazy load sub drivers#2622
Merged
aleclorimer merged 1 commit intomainfrom Jan 8, 2026
Merged
CHAD-17068: zigbee-humidity-sensor lazy load sub drivers#2622aleclorimer merged 1 commit intomainfrom
aleclorimer merged 1 commit intomainfrom
Conversation
|
Channel deleted. |
Test Results 71 files 480 suites 0s ⏱️ Results for commit 2d69ed8. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2d69ed8 |
cjswedes
approved these changes
Dec 11, 2025
Contributor
cjswedes
left a comment
cjswedes
left a comment
There was a problem hiding this comment.
The optimization to move the require "configurations" seems worthwhile on all these PRs because its often only used in device lifecycle handlers, and it contains a lot of constants, that can be gc'd when not in used.
|
|
||
|
|
||
| local battery_defaults = require "st.zigbee.defaults.battery_defaults" | ||
| local configurationMap = require "configurations" |
Contributor
There was a problem hiding this comment.
We should move this intodevice_init to allow for gc.
aleclorimer
force-pushed
the
zigbee-humidity-sensor-lazy-load-subdrivers
branch
2 times, most recently
from
1fec820 to
4b2bbcc
Compare
aleclorimer
force-pushed
the
zigbee-humidity-sensor-lazy-load-subdrivers
branch
from
4b2bbcc to
2d69ed8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lazy loading of
zigbee-humidity-sensorsub-drivers and copyright updates.