Matter Camera: fix devices being marked online due to capability inits #2688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driverSwitched event can be triggered in a few different ways, but since it was pointed to the same handler as doConfigure, code that should only be ran for new devices was being run when this event was received by the driver. This includes `initialize_camera_capabilities`, which resulted in offline devices being marked online. This change adds separate handling from driverSwitched, specifically excluding this function as well as `create_child_devices`.
|
Invitation URL: |
Test Results 71 files 480 suites 0s ⏱️ Results for commit e023765. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e023765 |
hcarter-775
approved these changes
Jan 8, 2026
nickolas-deboom
deleted the
fix/matter-camera-driver-switched-marking-devices-online
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
driverSwitchedevent can be triggered in a few different ways, but since it was pointed to the same handler asdoConfigure,code that should only be run for new devices was being run whenever this event was received by the driver. This includesinitialize_camera_capabilities, and resulted in offline devices being marked online. This change adds separate handling fordriverSwitched, specifically excluding this function as well ascreate_child_devices.