Matter Switch: Handle InitialPress during BILRESA scrolling#2789
Merged
hcarter-775 merged 1 commit intomainfrom Feb 20, 2026
Merged
Matter Switch: Handle InitialPress during BILRESA scrolling#2789hcarter-775 merged 1 commit intomainfrom
hcarter-775 merged 1 commit intomainfrom
Conversation
hcarter-775
requested review from
ctowns,
greens,
nickolas-deboom and
tpmanley
|
Channel deleted. |
Test Results 72 files 486 suites 0s ⏱️ Results for commit 8ebd6e4. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 8ebd6e4 |
perexis
approved these changes
Feb 19, 2026
tpmanley
reviewed
Feb 19, 2026
Comment on lines
53
to
57
| local num_presses_to_handle = 1 - (device:get_field(scroll_fields.LATEST_NUMBER_OF_PRESSES_COUNTED) or 0) | ||
| if num_presses_to_handle > 0 then | ||
| device:set_field(scroll_fields.LATEST_NUMBER_OF_PRESSES_COUNTED, 1) | ||
| rotate_amount_event_helper(device, ib.endpoint_id, 1) | ||
| end |
Contributor
There was a problem hiding this comment.
I think this is a little easier to understand. What do you think?
Suggested change
| local num_presses_to_handle = 1 - (device:get_field(scroll_fields.LATEST_NUMBER_OF_PRESSES_COUNTED) or 0) | |
| if num_presses_to_handle > 0 then | |
| device:set_field(scroll_fields.LATEST_NUMBER_OF_PRESSES_COUNTED, 1) | |
| rotate_amount_event_helper(device, ib.endpoint_id, 1) | |
| end | |
| local latest_presses_counted = device:get_field(scroll_fields.LATEST_NUMBER_OF_PRESSES_COUNTED) or 0 | |
| if latest_presses_counted == 0 then | |
| device:set_field(scroll_fields.LATEST_NUMBER_OF_PRESSES_COUNTED, 1) | |
| rotate_amount_event_helper(device, ib.endpoint_id, 1) | |
| end |
Contributor
Author
There was a problem hiding this comment.
works for me. I was trying to keep the same structure as the other 2 handlers but maybe that's more confusing than it is helpful
Contributor
There was a problem hiding this comment.
I brought it up because when num_presses_to_handle is > 0 that means it is 1, but then on lines 55 and 56 the value of 1 is being hardcoded instead of using num_presses_to_handle. Another option would be to replace those hardcoded 1's with num_presses_to_handle but I guess I thought this suggestion was a bit easier to read.
hcarter-775
force-pushed
the
add/initial-press-handling
branch
from
493d661 to
70cfe70
Compare
hcarter-775
force-pushed
the
add/initial-press-handling
branch
from
70cfe70 to
8ebd6e4
Compare
tpmanley
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Update the Bilresa subdriver to support scroll-style events with the InitialPress.
Summary of Completed Tests
Tested on-device.