Conversation
Device init messages must be disabled before adding the mock device to the test framework for these tests.
|
Channel deleted. |
Test Results 72 files 507 suites 0s ⏱️ Results for commit 1918c71. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1918c71 |
|
@hcarter-775 |
| end | ||
| end, | ||
| { | ||
| min_api_version = 15 |
There was a problem hiding this comment.
Was this tested against 15? HC 0.59 is running lua-libs v17.
There was a problem hiding this comment.
I put it at 15 because that is when the disable_startup_messages was included in the test framework, so in theory it should work all the way back to version 15 if we ever include those earlier versions
There was a problem hiding this comment.
Testing against 15 has unrelated failures due to stateless step capabilities in the driver. New capabilities in a driver are a separate issue that would need to be dealt with if we use those older api versions. Testing on 17 does pass since the capabilities are present
There was a problem hiding this comment.
I don't know if it makes sense to do backwards compat tests with the artificial limitation of capabilities not being generated, which is a UT only situation. To me, this should be worked around by the jenkins test framework rather than the devs, since new capabilities will continue to be made.
There was a problem hiding this comment.
If we ever include tests for lua libs <17 we will need to address that. I agree that a work around would be best done in jenkins when running the tests. For now I am opting for setting the min_api_version to what it should be, but I can change to 17 if people want.
There was a problem hiding this comment.
I think I'm wondering what will happen when we add statelessWindowStep (or whatever) in the next release and roll that out to the drivers. Will that cause everything to fail?
There was a problem hiding this comment.
Ill look into updating jenkins to be using the latest capabilities. IDRC if we do 15 or 17 as we likely aren't going to be adding 58 to our testing matrix in the future. The only way we'd go below 17 is if we wanted more support into the Cell hubs back on 52.
There was a problem hiding this comment.
I think we should support 58, right? We still have some tv hubs on 58, no? Calling this out since HQ caught a 58 bug in one of my PRs about a month ago.
There was a problem hiding this comment.
60 is almost fully released to TVs, so there is not much need to include it. 60 will be the lowest FW version out there (besides the ST Wifi hubs on 52).
3 participants
Device init messages must be disabled before adding the mock device to the test framework for these tests.
For release, this should go with the ledvance WWST commit in #2729