Skip to content

Fix duplicate profile check to handle deleted files #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nand-nor merged 2 commits into from
May 18, 2026
Merged

Fix duplicate profile check to handle deleted files #2976

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
758245b
Fix duplicate profile check to handle deleted files
nand-nor May 18, 2026
732cc20
Emit warning when profile files are deleted in PR
nand-nor May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .github/scripts/check_duplicates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

cwd = os.getcwd()
duplicate_pairs = []
deleted_profiles = []

def compare_component_capabilities_unordered(comp1, comp2):
for cap1 in comp1["capabilities"]:
Expand Down Expand Up @@ -112,9 +113,16 @@ def compare_components(prof1, prof2):
print('\nNEW PROFILE:\n%s is a profile! Comparing to other profiles...' % file)

os.chdir(file_directory)
for current_profile in os.listdir("./"):
new_profile = file_basename
new_profile = file_basename

# Skip deleted files and track them for warning
if not os.path.exists(new_profile):
print("Skipping %s - file was deleted" % new_profile)
deleted_profiles.append(file)
os.chdir(cwd)
continue

for current_profile in os.listdir("./"):
# compare to YAML files that are not the same file
# Compare only .yml files and only files that have not already been found to be a duplicate
if current_profile != new_profile and Path(current_profile).suffix == ".yml" and (current_profile, new_profile) not in duplicate_pairs:
Expand Down Expand Up @@ -145,7 +153,12 @@ def compare_components(prof1, prof2):
for duplicate in duplicate_pairs:
f.write("%s == %s\n" % (duplicate[0], duplicate [1]))
else:
f.write("Duplicate profile check: Passed - no duplicate profiles detected.")
f.write("Duplicate profile check: Passed - no duplicate profiles detected.\n")

if deleted_profiles:
f.write("\n:warning: **Deleted profile files detected:**\n")
for deleted in deleted_profiles:
f.write("- `%s`\n" % deleted)

with open("profile-comment-body.md", "r") as f:
print("\n" + f.read())