Skip to content

Conversation

@KKlimczukS
Copy link
Contributor

There were some changes on the plugin side, so sending a supportedWindowShadeCommands event is needed now for shades to work.

@tpmanley @MAblewiczS @ZWozniakS @MGoralczykS @PKacprowiczS

Please, take a look.

dkirker
dkirker previously approved these changes Sep 27, 2019
@dkirker
Copy link
Contributor

dkirker commented Sep 27, 2019

Do we need to get existing devices to send this event? We could either add a call in parse() to check if the attribute is set and if not send the event, or run a script to update it.

Also, does the mobile client not work if that attribute is not set?

cc @tpmanley

@tpmanley
Copy link
Contributor

If the plugin now requires this I would suggest creating the event in installed and also creating it in parse if it hasn't already been created. That way we won't have to run a script to update existing devices.

@KKlimczukS
Copy link
Contributor Author

@tpmanley @dkirker - according to Your suggestions - there are new changes in DTH.

log.debug "description:- ${description}"

// update existing devices
if (!state.supportedWindowShadeCommands) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be if (!device.currentValue("supportedWindowShadeCommands"))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of
if (!state.supportedWindowShadeCommands) ?

@KKlimczukS
Copy link
Contributor Author

@tpmanley
#11364
includes changes from this PR. I think we can close this one and focus on PR: 11364

@tpmanley
Copy link
Contributor

tpmanley commented Oct 10, 2019

I agree that we can close this PR. I addressed the same issue in #11355 and also generated the necessary event on all existing devices.

@tpmanley tpmanley closed this Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants