-
Notifications
You must be signed in to change notification settings - Fork 88.5k
ICP-11103 - sending a supportedWindowShadeCommands event #11341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do we need to get existing devices to send this event? We could either add a call in Also, does the mobile client not work if that attribute is not set? cc @tpmanley |
|
If the plugin now requires this I would suggest creating the event in |
…, updating existing devices in parse()
| log.debug "description:- ${description}" | ||
|
|
||
| // update existing devices | ||
| if (!state.supportedWindowShadeCommands) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be if (!device.currentValue("supportedWindowShadeCommands"))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of
if (!state.supportedWindowShadeCommands) ?
|
I agree that we can close this PR. I addressed the same issue in #11355 and also generated the necessary event on all existing devices. |
There were some changes on the plugin side, so sending a supportedWindowShadeCommands event is needed now for shades to work.
@tpmanley @MAblewiczS @ZWozniakS @MGoralczykS @PKacprowiczS
Please, take a look.