Skip to content

[ICP-11598] POPP Radiator Thermostat 'always online' workaround #12334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 27, 2019
Merged

[ICP-11598] POPP Radiator Thermostat 'always online' workaround #12334

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a56425b
A first approach, to make device to go 'offline' properly
PKacprowiczS Nov 20, 2019
c6e6bcf
Changes to enable setpoint manual and wireless change in same setup
Nov 26, 2019
dbc1a7f
Comment position adjustment
Nov 26, 2019
178ce0c
Combining both ThermostatSetpointReport handlers
Nov 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions devicetypes/smartthings/zwave-radiator-thermostat.src/zwave-radiator-thermostat.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ def initialize() {
}

def installed() {
state.isSetpointChangeRequestedByController = false
initialize()
}

Expand Down Expand Up @@ -135,7 +136,9 @@ def zwaveEvent(physicalgraph.zwave.commands.securityv1.SecurityMessageEncapsulat

def zwaveEvent(physicalgraph.zwave.commands.multicmdv1.MultiCmdEncap cmd) {
cmd.encapsulatedCommands().collect { encapsulatedCommand ->
zwaveEvent(encapsulatedCommand)
isPoppRadiatorThermostat() ? zwaveEvent(encapsulatedCommand, true) : zwaveEvent(encapsulatedCommand)
//in case any future device would support MultiCmdEncap
//and won't need any special handler, like POPP does
}.flatten()
}

Expand Down Expand Up @@ -174,9 +177,22 @@ def zwaveEvent(physicalgraph.zwave.commands.thermostatmodev2.ThermostatModeRepor
createEvent(map)
}

def zwaveEvent(physicalgraph.zwave.commands.thermostatsetpointv2.ThermostatSetpointReport cmd) {
def updateSetpoint(cmd) {
def deviceTemperatureScale = cmd.scale ? 'F' : 'C'
createEvent(name: "heatingSetpoint", value: convertTemperatureIfNeeded(cmd.scaledValue, deviceTemperatureScale, cmd.precision), unit: temperatureScale)
def setpoint = Float.parseFloat(convertTemperatureIfNeeded(cmd.scaledValue, deviceTemperatureScale, cmd.precision))
Copy link
Contributor

@greens greens Nov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason you have to do a type conversion here, but we didn't have to when just passing directly?

Copy link
Contributor Author

@PKacprowiczS PKacprowiczS Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type conversion is only really needed for state.cachedSetpoint, cause later it's used in Z-Wave commands and theirs constructors require numeric type values.
Although, as createEvent doesn't care whether it's string or float, I've used what I've got

state.cachedSetpoint = setpoint
createEvent(name: "heatingSetpoint", value: setpoint, unit: temperatureScale)
}

def zwaveEvent(physicalgraph.zwave.commands.thermostatsetpointv2.ThermostatSetpointReport cmd, isResponseOfWakeUp = false) {
if (!state.isSetpointChangeRequestedByController) {
updateSetpoint(cmd)
} else if (isResponseOfWakeUp) {
state.isSetpointChangeRequestedByController = false
updateSetpoint(cmd)
} else {
[:]
}
}

def zwaveEvent(physicalgraph.zwave.commands.sensormultilevelv5.SensorMultilevelReport cmd) {
Expand Down Expand Up @@ -227,7 +243,8 @@ def off() {
}

def setHeatingSetpoint(setpoint) {
if (isPoppRadiatorThermostat()) {
if (isPoppRadiatorThermostat() && device.status == "ONLINE") {
state.isSetpointChangeRequestedByController = true
sendEvent(name: "heatingSetpoint", value: setpoint, unit: temperatureScale)
}
setpoint = temperatureScale == 'C' ? setpoint : fahrenheitToCelsius(setpoint)
Expand Down