[ICP-12162]HEIMAN Scene Button: remove un-used button UI of scene keypad plugin #17908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpmanley
reviewed
Jan 13, 2020
|
|
||
| private addChildButtons(numberOfButtons) { | ||
| for(def endpoint : 1..numberOfButtons) { | ||
| for(def endpoint : 2..numberOfButtons) { |
Contributor
There was a problem hiding this comment.
I don't think this is the right fix. At the very least this will break the other devices that use this DTH. It appears to me that the reason there is an extra button is because this device is using the generic-4-button-alt UI Metadata. The only difference between that and generic-4-button is the former adds an extra button for the main component. Is there a reason you're not using generic-4-button for this device?
Contributor
Author
There was a problem hiding this comment.
hi, just tested with generic-4-button, this vid works for the device, I've modified the submit, please check again
tpmanley
approved these changes
Jan 14, 2020
ZouLianghuiS
added a commit
to ZouLianghuiS/SmartThingsPublic
that referenced
this pull request
Jan 15, 2020
FenMei007S
pushed a commit
to FenMei007S/SmartThingsPublic
that referenced
this pull request
Jan 15, 2020
qtwre
added a commit
to qtwre/SmartThingsPublic
that referenced
this pull request
Jan 30, 2020
* [WWST 5866]zigbee switch: add fingerprint for honyar 1 gang switch (SmartThingsCommunity#11463) Add fingerprint for honyar 1 gang switch * ICP-10136 - Zooz Power Strip: calling sendHubCommand() once with all commands (for all endpoints) (SmartThingsCommunity#11431) * ICP-10136 - calling sendHubCommand() once with all commands (for all endpoints) * ICP-10136 - decreased delay between commands send from refresh() to 200 milliseconds * WWST-5862 Added a FP for the ABL Light (SmartThingsCommunity#11458) * [WWST-4627] New DTH for Qubino On/Off Flush Thermostat 2 (SmartThingsCommunity#11380) * New DTH for Qubino On/Off Flush Thermostat 2 * Added mode change in preferences. * Changed vid and modified 'secure' method * WWST-5910 Add POPP Flow Stop to zwave-water-valve (SmartThingsCommunity#11467) * [ICP-11308] Send motion event in installed() to fix pairing without status (SmartThingsCommunity#11391) * Send motion event in installed() to fix pairing without motion - Everspring Indoor PIR * Add notificationType with event to send motion event to device. * add fingerprint for HONYAR switch * Simulated Device Preferences: Fix 'required' field on one of the enum prefs * ICP-10136 - Zooz Power Strip: calling sendHubCommand() once with all commands (for all endpoints) (SmartThingsCommunity#11431) (SmartThingsCommunity#11483) * ICP-10136 - calling sendHubCommand() once with all commands (for all endpoints) * ICP-10136 - decreased delay between commands send from refresh() to 200 milliseconds * ICP-10136 - Zooz Power Strip: calling sendHubCommand() once with all commands (for all endpoints) (SmartThingsCommunity#11431) (SmartThingsCommunity#11483) (SmartThingsCommunity#11484) * ICP-10136 - calling sendHubCommand() once with all commands (for all endpoints) * ICP-10136 - decreased delay between commands send from refresh() to 200 milliseconds * ICP-10136 - Zooz Power Strip: calling sendHubCommand() once with all commands (for all endpoints) (SmartThingsCommunity#11431) (SmartThingsCommunity#11483) (SmartThingsCommunity#11484) (SmartThingsCommunity#11485) * ICP-10136 - calling sendHubCommand() once with all commands (for all endpoints) * ICP-10136 - decreased delay between commands send from refresh() to 200 milliseconds * [WWST-5948] Zigbee Switch: add fingerprint for Terncy light socket (SmartThingsCommunity#11488) * ICP-11209 Added on command to the setColorTemp() (SmartThingsCommunity#11478) * [ICP-11078] Fibaro CO Sensor doesn't report high temperature warning (SmartThingsCommunity#11360) * Configuration change to enable temperature alarm. * Changed default value in parameter map. * Battery report fix and set temperatureAlarm event 'cleared' to be send by default * Changed configuration to enable acoustic on exceeding the temperature alarm. * [ICP-11187] Added "on" commands to the setColor() and setColorTemp() (SmartThingsCommunity#11479) * Added on commands to the setColor() and setColorTemp() * Added condition to the setColorTemp() * CHAD-3841 Low Battery Threshold Reporting (SmartThingsCommunity#11459) * CHAD-3841 Low Battery Threshold Reporting Sends a devicewatch event to register these devices for notifications when battery levels dip below certain thresholds. * add displayed: false * consolidates device watch events * DevWs for Most Target Limited containing containing SmartSense Motion Sensor and 1 more (SmartThingsCommunity#11462) * DevWs for Most Target Limited containing containing SmartSense Motion Sensor and 1 more * readd capability "Temperature Measurement" * WWST-2347 enable mcd for aeon minimote (SmartThingsCommunity#11207) * WWST-2347 enable mcd for aeon minimote * change isStateChange flag * set supportdbuttonvalues * enable update of child devices for migration to MCD * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Dual Switch (SmartThingsCommunity#11461) * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Dual Switch * Added fingerprint for EVA LOGIK Smart Plug 2CH * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Switch Generic (SmartThingsCommunity#11460) * [ICP-11154] Aurora Smart PIR Sensor - specified metadata with translations (SmartThingsCommunity#11468) * Simulated Device Preferences: Fixed type of 'number' input The number input type was 'integer' but that's not a valid type of a device preference. Fixed that and also added some additional number preferences with different types of ranges. * [ICP-11264] Providing new DTH for Everspring Outdoor Floodlight (SmartThingsCommunity#11383) * Reverting all changes in Z-Wave Motion Light Sensor and creating new DTH for Everspring Outdoor Floodlight. * Changed name of DTH to be more generic. * Fixed another wrong definition in tiles. * Couple of fixes * Added device check for configuration change. * [WWST-5902] Add POPP 10Year Smoke Sensor to zwave-smoke-alarm (SmartThingsCommunity#11481) * Add POPP 10Year Smoke Sensor to zwave-basic-smoke-alarm.groovy * WWST-5890 Fingerprint for POPP Smart Outdoor Plug (SmartThingsCommunity#11498) * CHAD-3841 Add Battery reporting thresholds for smartthings devices (SmartThingsCommunity#11499) Encode device watch values as JSON * ICP-11344 Everspring Radiator Thermostat: Configured automatic temperature reports every 15 minutes. (SmartThingsCommunity#11466) * WWST-5997/WWST-5998 Added FPs for Aeotec Recessed Door Sensors US/EU (SmartThingsCommunity#11573) * [WWST-6003/WWST-6004] Added FPs for Aeotec Range Extenders 7 US/EU (SmartThingsCommunity#11574) * Added FPs for Aeotec Range Extenders 7 US/EU * Update zwave-range-extender.groovy * Prevent logging of variables * [ICP-10361] Fibaro Heat Controller - additional temperature sensor connectivity check (SmartThingsCommunity#11451) * Code change which prevents "error indicator" to be shown as quasi correct temperature measurement. * Fixed faulty temperature check, alongside with more accurate status changes. * Forcing sending status event to child. * add fingerprint for eWeLink and SONOFF devices * [WWST-5914] POPP Radiator Thermostat integration (SmartThingsCommunity#11575) * POPP Radiator Thermostat integration * Removed 'offlinePingable' flag and fixed secure() method. * [ONEIOT-108] Simulated Device Preferences: added 'bool' input Both 'boolean' and 'bool' input types are supposed to be supported. * [ICP-11504] Added plug icon for POPP Smart Outdoor Plug (SmartThingsCommunity#11657) * Added plug icon for POPP Smart Outdoor Plug * Adjusted the configuration for the Popp Smart Plug * Child contact sensor for multi component devices (SmartThingsCommunity#11581) * Child contact sensor for multi component devices Device handlers for multi endpoint devices which have contact sensors endopints require child contact sensor DTH's. This generic child DTH serves the purpose and supports contact sensor, battery and health check. * Removed battery not required for contact endpoints * Update date * [WWST-5755] Added comment to zwave-lock to know to which name belongs to YRL 236. (SmartThingsCommunity#11741) * [WWST-5751] Add YRD156 Yale to zwave-lock.groovy (SmartThingsCommunity#11743) * Add Rooms Beautiful Range Extender to Zigbee Range Extender DTH (SmartThingsCommunity#11579) * add fingerprint for heiman temp/humidity sensor * [WWST-6039] Zigbee Motion Detector: add fingerprint for HEIMAN motion sensor (SmartThingsCommunity#11895) add fingerprint for heiman motion sensor * Axis Gear ST: Add support for Window Shade Preset in the new app (SmartThingsCommunity#11746) * [ICP-11505] Aeotec KeyFob Gen5 lacks basic functionality (SmartThingsCommunity#11742) * Providing fixes to make sure that Aeotec KeyFob Gen5 will work correctly. * Added ocfDeviceType * Added comment about Aeotec KeyFob event handling formula * add fingerprint for heiman sos button * [WWST-5980]zigbee switch: add fingerprint for heiman 1 gang switch (SmartThingsCommunity#12164) add fingerprintf for heiman 1 gang switch * [ICP-11070] Modified zwave-siren DTH, add capability Tamper for Everspring Siren. (SmartThingsCommunity#11390) * Modified zwave-siren DTH, add capability Tamper for Everspring Siren. * Add tamper capability to zwave-siren, add vid to Everspirng Siren. * Add second event for Everspring Siren * Clear tamper when receive off() * Fix for clear tamper event. * SmartSense Multi/Motion/Button: Set correct Korean join names https://smartthings.atlassian.net/browse/ONEAPP-19538 * DevWs for RoomsBeautiful containing containing Curtain (SmartThingsCommunity#11257) * DevWs for RoomsBeautiful containing containing Curtain * switched to use ZigBee Window Shade Capability * added dkirker's updates * changed vid to "generic-shade-4" * changed DTH name and removed "pause" command * fixed indenting on github * fixed indenting * Update rooms-beautiful-curtain.groovy * - * Remove old DTH and update indenting for uniformity * add fingerprint for HEIMAN water leakage sensor * WWST-4999 - Support for "Ikea Open/Close remote E1766" (SmartThingsCommunity#11497) * WWST-4999 - Support for "Ikea Open/Close remote E1766" * WWST-4999 - Second FP added * WWST-4999 - deviceJoinName changed to IKEA TRÅDFRI Open/Close Remote * DTH for WWST-4943, VISION Z-Wave Recessed D/W Sensor ZD 2105BR-5 - ANZ (SmartThingsCommunity#12174) * DTH for WWST-4943, VISION Z-Wave Recessed D/W Sensor ZD 2105BR-5 - ANZ * ICP-11490 ilumin bulb reporting intermediate level change values (SmartThingsCommunity#11745) * ICP-11490 ilumin bulb reporting intermediate level change values I think we're just querying for the level value too soon after setting it. This just adds in a small static delay to account for transmission time. * increase delay to match other DTHs * WWST-2347 Aeon Minimote: Don't create child devices if they already exist (SmartThingsCommunity#12328) If a minimote is joined with a different DTH that creates child devices and then is switched to the Aeon Minimote DTH it was getting an exception because it was trying to recreate the child devices. This change prevents it from recreating the child devices when 'installed' is called. * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Dual Switch (SmartThingsCommunity#11963) * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Dual Switch * Minoston Smart Plug 2CH * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Switch Generic (SmartThingsCommunity#11962) * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Switch Generic * Minoston Outdoor Smart Plug * fix honyar usb port can't be control issue * fix device offline issue * WWST-5496, WWST-5505 - added vid: generic-color-temperature-bulb-2700K-5000K to fingerprint * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Dimmer Switch Generic * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Switch Generic * ICP-11609 send child events as the parent as well (SmartThingsCommunity#12402) * ICP-11609 send child events as the parent as well for OneApp to change the status of the main device on the all devices view, events need to be duplicated to the parent * remove unnecessary createEvent call * add fingerprint for heiman wall socket * DevWs for FirstAlert containing containing Z-Wave Smoke Alarm (SmartThingsCommunity#12335) DevWs for FirstAlert containing containing Z-Wave Smoke Alarm * [ICP-11598] POPP Radiator Thermostat 'always online' workaround (SmartThingsCommunity#12334) * A first approach, to make device to go 'offline' properly * Changes to enable setpoint manual and wireless change in same setup * Comment position adjustment * Combining both ThermostatSetpointReport handlers * WWST-5894 Add POPP Solar Outdoor Siren to zwave-siren (SmartThingsCommunity#13514) * update model code * add fingerprint for heiman 3 gang switch * ICP-11703 - increased a "minimum number of seconds between reports" * [WWST-1994] New DTH Z-Wave Basic Window Shade (Aeotec Nano Shutter) (SmartThingsCommunity#4006) * Initial commit for DTH Z-Wave Basic Window Shade. * Added setButton() method to provide OneApp compatibility. * ocfDeviceType added, fix for >1 time "pause" command selected * Metadata definition * Giving an user an oppurtinity to change direction of rolling/unrolling blinds * Preferences change and sending availableCurtainPowerButtons as JSON * ICP-11759 Added switch icon for AOne Smart Strip Controller (SmartThingsCommunity#13611) * WWST-5898 Add POPP Smoke Detector with Siren to zwave-basic-smoke-alarm (SmartThingsCommunity#13513) * WWST-6203 DTH-Fibaro KeyFob-FGKF-601 AU (SmartThingsCommunity#13610) * update heiman motion sensor manufacture * Allow for custom smartapp name when saving Button Controller * DevWS: ZP3111US 4-in-1 Motion added to zooz 4-in-1 DTH (SmartThingsCommunity#11361) * fix remain battery percentage incorrect issue * DevWs for Most Target Limited containing containing ZigBee Switch Power (SmartThingsCommunity#12030) * DevWs for Most Target Limited containing containing ZigBee Switch Power * add ocf type for sub meter * add fingerprint for heiman 2 gang switch * add fingerprint for heiman co sensor and contact sensor * [CHAD-4106] Set Association Group 1 at initialized() and once later if needed (SmartThingsCommunity#14372) This is a hotfix to cover off a bug introduced in hubcore 28 that stopped sending association sets to group 1 automatically unless they were Z-Wave Plus devices. We determined that this might result in certain devices failing to send unsolicited updates in the case of events like smoke detection. * WWST-6234 Fibaro Flood Sensor checkinterval is too short (SmartThingsCommunity#14449) The device's checkinterval was set to be identical to its reporting interval, which means that one missed checkin could mark the device offline. * WWST-4958 Add fingerprint for Vision Outdoor Siren (SmartThingsCommunity#14749) * [ICP-11716] Zigbee Window Shade Battery: Handle open/close/setLevel commands when the shade is already moving (SmartThingsCommunity#13836) * Remove outdated Korean translations for device preferences * ICP-11818 Marked Fibaro KeyFob as untracked (SmartThingsCommunity#14755) Enabled 3x pressed and down_held * ICP-11733 Enrolling child device in DeviceWatch (SmartThingsCommunity#14756) Fibaro child temperature sensor needs to have its online/offline state manually controlled * WWST-6239 add fingerprint for heiman gas sensor (SmartThingsCommunity#14849) * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Dual Switch (SmartThingsCommunity#14668) * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Dimmer Switch Generic (SmartThingsCommunity#14661) * WWST-6011 add fingerprint for Neo_Coolcam_Z-Wave_Siren_AS-AB02Z (SmartThingsCommunity#14757) * Aeon Minimote/Zigbee Multi Button: Fix display in the new app These two DTHs were missing the ocfDeviceType of x.com.st.d.remotecontroller. The effect of that is they had the wrong icon and didn't show automations in the device view. https://smartthings.atlassian.net/browse/CHAD-4201 * HEIMAN co sensro:fix battery info not display issue * Revert "[CHAD-4106] Set Association Group 1 at initialized() and once later if needed (SmartThingsCommunity#14372)" (SmartThingsCommunity#15345) This reverts commit e71cf45. * WWST-4627 Changed setpoint range as asked by Qubino (SmartThingsCommunity#15257) * add DTH for heiman emergency button * [WWST-6302]add fingerprint for HEIMAN Smoke Sensor(HS3SA) (SmartThingsCommunity#15260) * DevWs for NIE-TECH CO., LTD. containing containing Z-Wave Switch Generic (SmartThingsCommunity#14750) * add fingerprint for heiman sence keypad * add fingerprint for heiman scene keypad * Added initial settings in installed for Innr RB185C bulb * [ICP-10897] Force Müller Licht Bulb White+Color to report white on join Force Müller Licht Bulb White+Color to report white on join This device was incorrectly reporting a color on join even though it was actually showing white. * ICP-11933 Set Vision Siren to use metadata with Tamper tile (SmartThingsCommunity#17467) * DVCSMP-3664 Clear up common exceptions. (SmartThingsCommunity#15112) * Clear up common exceptions. Fibaro Motion Sensor - code was erroneously added checking the value of a preference that does not exist. Zigbee Thermostat - reporting configured messages without values would cause exceptions to be thrown during parsing Lock without codes - adds old-style OEM parsing to this DTH. The method call had been copy-pasted, but the method had not. Removes all references to codes from the original method in Z-Wave Lock. * fix spaces -> tabs * ICP-12063 Added vid with the correct color temp range for Innr Smart Bulb Color (SmartThingsCommunity#17854) * fix heiman emergency button health check not work issue * CHAD-4257 Release EcoSmart 4-button remote DTH (SmartThingsCommunity#17396) * DTH for WWST-6374 and WWST-6379, Sengled Element Touch * DTH for WWST-6384- Sengled - LED Floodlight with Motion * Bug Fix for ICP-11992 and ICP-11913 * ZLL Dimmer Bulb: Add fingerprint for TRADFRI bulb E26 W opal 1000lm (SmartThingsCommunity#17856) * Added FP for Aeotec Water Sensor 6 - AU region (SmartThingsCommunity#17986) * CHAD-4014, WWST-6257 Add Window Shade Preset support to Zigbee Window Shades, Update preference text (SmartThingsCommunity#12255) * CHAD-4014 Add Window Shade Preset support to Zigbee Window Shades * Update device preferences based on WWST-6257 * WWST-6257 Update preference text for devices using Window Shade Preset (SmartThingsCommunity#18001) * [ICP-12162]HEIMAN Scene Button: remove un-used button UI of scene keypad plugin (SmartThingsCommunity#17908) * [WWST-6405] SmartPower Outlet: Add fingerprint for Sercomm Smart Power Plug - SZ-ESW01-AU (SmartThingsCommunity#17914) * [WWST-6391] Zigbee Lock: Add fingerprint for Lockwood Smart Lock YDD-D4F0 TSDB (SmartThingsCommunity#17911) * [WWST-6394] SmartSense Moisture Sensor: Add fingerprint for Sercomm Water Leak Detector - SZ-WTD03 (SmartThingsCommunity#17912) * CHAD-4088 Remove legacy "status" variable from SmartSense Multi and S… (SmartThingsCommunity#15909) * CHAD-4088 Remove legacy "status" variable from SmartSense Multi and SmartSense Garage Door * small fixes * CHAD-4089 Remove legacy "status" variable from SmartSense MultiSensor (SmartThingsCommunity#15908) * CHAD-4089 Remove legacy "status" variable from SmartSense MultiSensor * small fixes * [WWST-5161] Added and integrated Everspring Wall Switch (SmartThingsCommunity#17872) * Added and integrated Everspring Wall Switch * Added missing supproted button values for the child button * [ICP-12169]HEIMAN wall scene keypad:fix automation issue (SmartThingsCommunity#17985) * fix automation issue * change vid to fix quick control issue * [ICP-12063] ZLL RGBW Bulb: Fix format of vid in fingerprint This bug was causing the following exception during deploy: ``` groovy.lang.MissingMethodException: No signature of method: script_dth_metadata_220861c6_2bd3_4841_9db9_2c6925a26ddc.fingerprint() is applicable for argument types: (java.util.LinkedHashMap, java.lang.String) values: [[profileId:C05E, inClusters:0000, 0003, 0004, 0005, 0006, 0008, 0300, ...], ...] ``` * Curb Connected Services flag * WWST-6274 - added fingerprint for Ikea TRÅDFRI LED bulb E27 806 lumen, wireless dimmable, warm white opal white (SmartThingsCommunity#18030) WWST-6274 - added fingerprint for Ikea TRÅDFRI LED bulb E27 806 lumen, wireless dimmable, warm white opal white * SmartSense Motion Sensor: Update battery calculation for SmartThings Motion Sensor The manufacturer asked us to calculate the percentage remaining using a specific formula which effectively changes the minimum operating voltage from 2.1V to 2.4V. If they ever update the FW to do this on the device we will need to also update the DTH to only do this calculation for older FW. https://smartthings.atlassian.net/browse/CHAD-4299 * WWST-6420 - Added a fingerprint for Gledopto RGB+CCT LED Controller (SmartThingsCommunity#18063) WWST-6274 - Added a fingerprint for Gledopto RGB+CCT LED Controller * WWST-6439 DTH for NeoColCam for MY region (SmartThingsCommunity#18067) * DVCSMP-4823 Fibaro Single Switch sending events encapsulated (SmartThingsCommunity#18081) Likely as a result of multichannel association changes, newly-added fibaro single switch devices have been communicating with some users using encapsulated messages. This should handle those messages. * Language translations for the "Temperature Offset" device preference These DTHs have a single device preference called "Temperature Offset". There are other DTHs that also have this device preference but they aren't included here because they have other device preferences that we don't yet have translations for. In other words, we're trying to deploy all the device preferences for a given DTH at once. https://smartthings.atlassian.net/browse/CHAD-4343 * [WWST-6400] SmartSense Multi Sensor: Add fingerprint for Sercomm Door and Window Sensor - SZ-DWS04 * [WWST-6137, WWST-6155, WWST-6142, WWST-6169, WWST-6186, WWST-6192, WWST-6197] EZEX switch fingerprints (SmartThingsCommunity#18086) * [WWST-6110, WWST-6146] EZEX fingerprint of zigbee-switch.groovy file. (SmartThingsCommunity#18085) * [WWST-5278] EZEX Plug fingerprint of zigbee-switch-power.groovy (SmartThingsCommunity#18089) * CHAD-4316 Remove "alarmState" custom attribute from zwave smoke alarm (SmartThingsCommunity#18116) * CHAD-4316 Remove "alarmState" custom attribute from zwave smoke alarm We're moving away from custom attributes. This PR should match the work done to remove this attribute from hubcore. * Revert "CHAD-4014, WWST-6257 Add Window Shade Preset support to Zigbee Window Shades, Update preference text (SmartThingsCommunity#12255)" (SmartThingsCommunity#18118) This reverts commit 8d19ffe. * DevWs for RoomsBeautiful containing containing Curtain (SmartThingsCommunity#18082) * fixes a strange whitespace error introduced by dev workspace submission * Add TRÅDFRI LED bulb E27 250 lumen to zigbee-dimmer.groovy * WWST-6268 Add Ikea TRÅDFRI LED bulb E27 806 lumen to zigbee-white-color-temperature-bulb.groovy (SmartThingsCommunity#18128) * ICP-11933 Remove tamper capability from Vision siren (SmartThingsCommunity#18141) * DVCSMP-4826 Hotfix smartsense multi tile (SmartThingsCommunity#18143) my update to change the tile display in classic used "state" instead of "attributeState" resulting in nothing being displayed. * CHAD-4375 Check if child devices exist before creating in EcoSmart Remote DTH The original implementation of the EcoSmart remote DTH did not check if child devices existed before attempting to create them. This would result in duplicate child devices being created which would end up resulting in an error/crash. This manifested as being unable to change the DTH from self-published to official releases of this specific DTH. * WWST-6280 Ikea TRÅDFRI LED bulb E27 (SmartThingsCommunity#18807) WWST-6280 Ikea TRÅDFRI LED bulb E27 1000 lumen, wireless dimmable, white spectrum opal white Co-authored-by: FenMei007S <40883570+FenMei007S@users.noreply.github.com> Co-authored-by: Tom Manley <tom.manley@gmail.com> Co-authored-by: Konrad K <33450498+KKlimczukS@users.noreply.github.com> Co-authored-by: chw-choi <56910698+chw-choi@users.noreply.github.com> Co-authored-by: Kianoosh Karami <kianoosh.karami@smartthings.com> Co-authored-by: PKacprowiczS <41617389+PKacprowiczS@users.noreply.github.com> Co-authored-by: MGoralczykS <42434140+MGoralczykS@users.noreply.github.com> Co-authored-by: Steven Green <steven.green@smartthings.com> Co-authored-by: ZWozniakS <48519140+ZWozniakS@users.noreply.github.com> Co-authored-by: ADUROSMART ERIA <52692745+adurosmart@users.noreply.github.com> Co-authored-by: sky-nie <54890556+sky-nie@users.noreply.github.com> Co-authored-by: Vinay Rao <3150991+workingmonk@users.noreply.github.com> Co-authored-by: rboy1 <3846367+rboy1@users.noreply.github.com> Co-authored-by: Donald Kirker <donald.kirker@openmobl.com> Co-authored-by: AXIS Labs Share <axislabsshare@gmail.com> Co-authored-by: devropes <54644824+devropes@users.noreply.github.com> Co-authored-by: ZouLianghuiS <lianghui.zou@samsung.com> Co-authored-by: ganeshasprabhu <45236237+ganeshasprabhu@users.noreply.github.com> Co-authored-by: Winniewen18 <51807434+Winniewen18@users.noreply.github.com> Co-authored-by: parasthakkar-newell <43554269+parasthakkar-newell@users.noreply.github.com> Co-authored-by: SureshS2 <45850090+SureshS2@users.noreply.github.com> Co-authored-by: VisionTaiwan1983 <48902294+VisionTaiwan1983@users.noreply.github.com> Co-authored-by: Broderick Carlin <34199479+BroderickCarlin@users.noreply.github.com> Co-authored-by: GSzabados <35445496+GSzabados@users.noreply.github.com> Co-authored-by: rajendrasamsung <raje_ndra.s@samsung.com> Co-authored-by: Juhaki Park <37175353+juhaki@users.noreply.github.com> Co-authored-by: Mariusz A <m.ablewicz@samsung.com>
KKlimczukS
pushed a commit
to KKlimczukS/SmartThingsPublic
that referenced
this pull request
Feb 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tpmanley , @greens , please have a review of my PR, thanks