This repository was archived by the owner on Sep 22, 2022. It is now read-only.
feat: remove managed config for default channel when deleting that channel #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
rossiam
force-pushed
the
rm-default-channel-config
branch
from
d53c353 to
66b63cb
Compare
john-u
approved these changes
Sep 20, 2022
Contributor
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user deletes a channel that is configured (via a managed config value) to be the default channel, remove that config value. The user could still have it configured on a another machine or another user could be using the same one but this will help in most cases where this would come up.
Types of Changes
npm run lintproduces no warnings/errors)