Skip to content

refactor: convert deviceprofiles:create command to yargs#735

Merged
rossiam merged 1 commit intoSmartThingsCommunity:yargsfrom
rossiam:yargs-deviceprofiles-create
May 20, 2025
Merged

refactor: convert deviceprofiles:create command to yargs#735
rossiam merged 1 commit intoSmartThingsCommunity:yargsfrom
rossiam:yargs-deviceprofiles-create

Conversation

@rossiam
Copy link
Copy Markdown
Collaborator

@rossiam rossiam commented May 19, 2025

  • converted deviceprofiles:create command to yargs
  • updated relevant unit tests
  • did not write new unit tests yet; this command should be converted to use input-item module

@rossiam rossiam requested a review from a team May 19, 2025 16:00
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2025

⚠️ No Changeset found

Latest commit: 7d2db3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rossiam rossiam force-pushed the yargs-deviceprofiles-create branch from 21eb01d to 27eab32 Compare May 19, 2025 16:04

/**
* Convert the `DeviceProfile` to a `DeviceProfileCreateRequest` by removing fields which can't
* be included in an create request.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a create request"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@rossiam rossiam force-pushed the yargs-deviceprofiles-create branch from 27eab32 to 7d2db3f Compare May 20, 2025 18:31
@rossiam rossiam merged commit 54907e3 into SmartThingsCommunity:yargs May 20, 2025
4 checks passed
@rossiam rossiam deleted the yargs-deviceprofiles-create branch May 20, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants