Skip to content

Conversation

@stdk-scm
Copy link
Collaborator

@stdk-scm stdk-scm commented Jan 20, 2021

Marking lists

  • I have read the Contributing Guidelines.

  • I have read the Samsung Individual CLA and agree with it

    • We (SmartThings Device SDK team) may ask you to sign it for larger changes. In this case, once we receive it, we'll be able to accept your pull requests according to relevant laws.
  • I submitted this PR against the correct branch:

    • This pull-request is based on the latest develop branch.
    • I have ensured local tests pass about my code changes.

License

Your contribution will be licensed under the Apache License Ver2.0.

YongsulOh and others added 4 commits January 19, 2021 13:05
…e apps

 - Current iot-core needs to use 64bits values in cJSON such as "provisioningTs"
   but NEWLIB_LIBRARY_LEVEL_NANO does not support 64bits value handling with sprintf
   so we need to change by NEWLIB_LIBRARY_LEVEL_NORMAL for all esp8266 sample apps
 - Also remove all unused cJSON patches for NEWLIB_LIBRARY_LEVEL_NANO's sprintf issue
 - This patch-set will be prevent following 'forcely assert situation'

  | "Library newlib of nano mode does not support double or long-long format, please enable newlib normal mode."
Signed-off-by: stdk-scm <63764571+stdk-scm@users.noreply.github.com>
* internal/develop_rel_1_5_7:
  Sync-up with iot-core 1.5.7
  esp8266: Use CONFIG_NEWLIB_LIBRARY_LEVEL_NORMAL for all esp8266 sample apps
Copy link

@YongsulOh YongsulOh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@stdk-scm stdk-scm merged commit 0a6ee1b into develop Feb 1, 2021
@stdk-scm stdk-scm deleted the develop_rel_1_5_7 branch March 10, 2021 11:01
@stdk-scm stdk-scm restored the develop_rel_1_5_7 branch March 10, 2021 11:02
@YongsulOh YongsulOh deleted the develop_rel_1_5_7 branch March 31, 2021 08:02
pull bot pushed a commit to davidpolite/st-device-sdk-c-ref that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants