Skip to content

add nested attributes locking, add before clone content written filter (WP-880)#522

Merged
vsolovei-smartling merged 6 commits into
masterfrom
WP-880-nested-attributes-locking
Mar 20, 2024
Merged

add nested attributes locking, add before clone content written filter (WP-880)#522
vsolovei-smartling merged 6 commits into
masterfrom
WP-880-nested-attributes-locking

Conversation

@vsolovei-smartling

Copy link
Copy Markdown
Contributor

No description provided.

$parents = explode(self::NESTED_ATTRIBUTE_SEPARATOR, $parents);
}

$pointer = &$array;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it pointer?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean why accessing through &

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked, now part of ArrayHelper

@vsolovei-smartling vsolovei-smartling merged commit 8d235ca into master Mar 20, 2024
@vsolovei-smartling vsolovei-smartling deleted the WP-880-nested-attributes-locking branch March 20, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants