fix target content not created (WP-889)#530
Merged
Merged
Conversation
| IFS=';' read -a array <<< "${DEPENDENCIES}"; for plugin_name in "${array[@]}"; do ${WPCLI} plugin install $plugin_name --activate-network; done && \ | ||
| if [ "latest" != "${ACF_PRO_VERSION}" ]; then DLINK="${DLINK}&t=${ACF_PRO_VERSION}"; fi && \ | ||
| DLINK="https://connect.advancedcustomfields.com/index.php?a=download&p=pro&k=${ACFPRO_KEY}" && \ | ||
| DLINK="https://smartling-connectors-storage.s3.amazonaws.com/wordpress/acf_pro/advanced-custom-fields-pro.5.11.zip" && \ |
Contributor
Author
There was a problem hiding this comment.
Not issue related, but prevented builds in ci. The link now has an additional dynamic parameter when copied from the acf account page, and without it 403 status is returned
dimitrystd
reviewed
May 30, 2024
| { | ||
| return (int)$this->db->getRowArray("SELECT COUNT(*) cnt from $this->tableName")['cnt']; | ||
| return (int)$this->db->getRowArray( | ||
| "SELECT SUM(LENGTH(submission_ids) - LENGTH(REPLACE(submission_ids, ',', '')) + 1) cnt from $this->tableName" |
Contributor
Author
There was a problem hiding this comment.
As we now store the submissionIds in a comma separated string, it's possible to count submissions per db row by calculating the count of commas in a column
Contributor
There was a problem hiding this comment.
we store array of values as a string? what is the data type of this column?
Contributor
Author
There was a problem hiding this comment.
we store array of values as a string? what is the data type of this column?
Type is text
dimitrystd
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.